Commit 508b028a authored by Simon Glass's avatar Simon Glass Committed by Tom Rini

mkimage: Correct file being closed twice in fit_import_data()

The code flows through to the end of the function, so we don't need another
close() before this. Remove it.

Reported-by: Coverity (CID: 138504)
Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
Reviewed-by: default avatarTom Rini <trini@konsulko.com>
parent 9cff2d1e
......@@ -530,6 +530,7 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
if (fd < 0) {
fprintf(stderr, "%s: Can't open %s: %s\n",
params->cmdname, fname, strerror(errno));
ret = -EIO;
goto err;
}
if (write(fd, fdt, new_size) != new_size) {
......@@ -538,7 +539,6 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
ret = -EIO;
goto err;
}
close(fd);
ret = 0;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment