Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • chatty chatty
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 313
    • Issues 313
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Librem5
  • chattychatty
  • Issues
  • #686
Closed
Open
Issue created Mar 12, 2022 by Chris Talbot@kop316Contributor

mmsd: Incorrect gsize to int conversion

cc @evangelos.tzaras

In commit 9c627f52

max_attach_size was changed from an int to a gsize. However, max_attach_size is taken from chatty here:

https://source.puri.sm/Librem5/chatty/-/blob/master/src/mm/chatty-mmsd.c#L1367

if (g_variant_dict_lookup (&dict, "TotalMaxAttachmentSize", "i", &max_attach_total_size))

And the conversation from int to gsize is incorrect. If mmsd-tng is using 11000000, chatty reports:

12:47:50.7616          chatty-mmsd[12339]:   DEBUG: TotalMaxAttachmentSize is set to 187647122262240

This is undesirable, as now Chatty will try to send images to mmsd-tng that are too large.

Edited Mar 12, 2022 by Chris Talbot
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking