window: don't access inexistent header_bar (!5) · Merge requests · Librem5 / chatty · GitLab

Snippets Groups Projects

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this page for instructions on how to get full permissions. Sorry for the inconvenience.

source.puri.sm migrated to a new server, see new ssh key fingerprint.

This is an archived project. Repository and other project resources are read-only.

Merged Guido Gunther requested to merge guido.gunther/chatty:header-bar into master 6 years ago

A HdyHeaderBar named header_bar does not exist in chatty-window.ui leading to:

    (chatty:8445): GLib-GObject-CRITICAL **: 10:36:26.069: g_object_set: assertion 'G_IS_OBJECT (object)' failed

Approval is optional

Activity

Adrien Plazas @adrien.plazas · 6 years ago

Owner

Woops, thanks for catching that one up, can you also remove its declaration?
Guido Gunther added 1 commit 6 years ago
added 1 commit

b5d69550 - window: don't access inexistent header_bar

Compare with previous version
Guido Gunther @guido.gunther · 6 years ago

Author Owner

I wondered why the compiler didn't warn me:

!7 (merged)

(not that I shouldn't have noticed myself). I have another MR that turns on more warnings but I'll let @andrea.schaefer deal with the fallout first.

Edited 6 years ago by Guido Gunther
Andrea Schaefer merged 6 years ago

merged
Andrea Schaefer mentioned in commit 62b9e579 6 years ago

mentioned in commit 62b9e579

Please register or sign in to reply