lib/bluetooth-pairing-dialog.c: In function ‘bluetooth_pairing_dialog_set_mode’:
include/glib-2.0/glib/gmacros.h:928:7: warning: ‘help’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  928 |    if (expr)                                    \
      |       ^
lib/bluetooth-pairing-dialog.c:69:8: note: ‘help’ was declared here
   69 |  char *help;
      |        ^~~~

Spotted by Mohammed Sadiq <sadiq@sadiqpk.org>

The alias can be overridden by third-parties and will be used by
bluetoothd to set the externally visible name, so we need to use it
rather than the (usually computationally) set name.

Closes: #50

I've encountered an intermittent GNOME Shell crash when needrestart[1]
is allowed to restart system services that are using outdated shared
libraries, which sometimes includes BlueZ. The crash seems to involve
signals being delivered to a freed BluetoothClient, which can be avoided
by using g_signal_connect_object(). I haven't encountered the crash
since applying this change, although since it was always intermittent
I cannot be sure that it is fully solved.

This might be caused by using the Bluetooth Quick Connect shell
extension[2], which will create and destroy a BluetoothClient when the
extension is loaded and unloaded, which will in turn happen when the
screen is locked (due to extensions being disabled in the lock screen).

[1] https://github.com/liske/needrestart
[2] https://extensions.gnome.org/extension/1401/bluetooth-quick-connect/



Signed-off-by: Simon McVittie <smcv@debian.org>
Bug-Debian: https://bugs.debian.org/932405