Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • G gnome-contacts
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Librem5
  • debs
  • gnome-contacts
  • Issues
  • #43
Closed
Open
Issue created Sep 12, 2020 by Clayton Craft@craftyguy

Compilation failure with Vala 0.50.0

Building gnome-contacts with vala 0.50.0 fails:

../src/contacts-avatar-utils.vala:129.11-129.20: error: syntax error, no expression allowed between array brackets
    const double[,3] GNOME_COLOR_PALETTE = {
          ^^^^^^^^^^

This fails because of this patch in vala that bubbles up the syntax error in the compiler:

commit 4244751bdf58a397a922f352284c26a5fac49a69 (refs/bisect/bad)
Author: Rico Tzschichholz <ricotz@ubuntu.com>
Date:   Thu Jul 2 13:11:52 2020 +0200

    vala: Don't loose invalid_syntax when copying array type for local variable

    Fixes https://gitlab.gnome.org/GNOME/vala/issues/942

Your branch is missing this simple upstream patch:

https://gitlab.gnome.org/GNOME/gnome-contacts/-/commit/22ac2c6fecc98efd11d96dc3e04938b8777a3510

Edited Sep 12, 2020 by Clayton Craft
Assignee
Assign to
Time tracking