GitLab

device-mapper: Fix a crash when setting display

Closes #4

See merge request Librem5/gnome-settings-daemon!2

The details can be NULL. So guard against dereferencing
NULL pointers by setting the default value.

Closes: https://source.puri.sm/Librem5/gnome-settings-daemon/issues/4

common: Limit minimum brightness to 10

See merge request Librem5/gnome-settings-daemon!3

Allowing the brightness to be zero might led the screen to be completely
dark blocking the user to see the display. So Let's limit minimum brightness
level to 10 percent.

Heavily based on code from nm-applet.

Follow-Ups:
   - Allow to store SIM in keyring
   - Handle PUKs? (or do that in g-c-c)

(cherry picked from commit 94baaea8)

The gtk modules xsetting may contain a ':' separated list of modules,
where the order is meaningless. In order to avoid tripping with the
unexpected order, split and sort it before doing our checks.

(cherry picked from commit a66ab7cc)

The xsettings test is failing with:

/home/carlos/Source/gnome/gnome-settings-daemon/plugins/xsettings/test.py:84: PyGIDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "schema" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
  self.settings_sound = Gio.Settings('org.gnome.desktop.sound')

(cherry picked from commit 63e325a4)

Michael Catanzaro authored Sep 09, 2016 and Jeremy Bicha committed Jan 08, 2019

...unless the power button action is actually set to NOTHING.

By default, it's set to suspend, but the user's computer might not
support suspend. Instead of doing nothing at all, fall back to
displaying the interactive shutdown dialog instead.

This doesn't require any UI changes, because the control-center option
for power button action is now only displayed for computers that do
support suspend (since GNOME #764508).

https://bugzilla.gnome.org/show_bug.cgi?id=771552
(cherry picked from commit 50ae2389)

Hans de Goede authored Oct 21, 2018 and Jeremy Bicha committed Jan 08, 2019

Some bluetooth keyboards have only 5 rows of keys, so the top row has the:
1-9, 0, -, + keys. These not only double as function keys using Fn + key,
but also as media-keys, e.g. next/prev song, using Ctrl + Fn + key.

Unfortunately the firmware for these keyboards is somewhat buggy and when
sending media keys they send along the Ctrl modifier, so we receive e.g.
"Ctrl + next-song" this commit adds bindings for Ctrl + media-key for the
media-keycodes send by these keyboards, so that these work as expected.

(cherry picked from commit 2d344c5c)

Andreas Henriksson authored Dec 30, 2018 and Jeremy Bicha committed Jan 08, 2019

Since hwdb (systemd) 240, the old Goldstar name has been
replaced by LG.

Introduce a helper function to allow both old and new name
to pass the assertion check.

Fixes: #126
(cherry picked from commit 0c49abcd)

The linear interpolation done for the color temperature would fail if
the value is exactly 0 or 1. Such values can be hit, so the we need to
accept them in normal operations.

Fixes #92

The default encoding for GIOChannel is UTF-8, but rfkill event is binary
data. If the value is invalid UTF-8, gsd-rfkill-manager will fail to
receive rfkill event.

On some slow tablets 1 second is not enough for the power-button press
which wakes the tablet from suspend to get processed by g-s-d. This
causes the tablet to immediately resuspend when woken using the
power-button and on tablets the power-button often is the only way to
wake the device.

Unfortunately this feature is not ready for wider consumption. Also, we
will need more invasive changes to properly fix this issue, which makes
it hard to add a runtime option for it in the short term.

For this reason, revert the change again but leave a way to re-enable it
at build time if it really is desired. See NEWS for more details.

We have always been leaking the GSource which is re-created every minute
to check the current night light state. Unfortunately, now that we are
correctly using the timerfd, we not only leak some memory but also the
file descriptor, causing major issues.

Fixes #91

This improves the logic for closing notifications a bit either closing
the UPS notification or the device notification. This is not a big
improvement through, ideally we would keep track of the notifications on
a per-device basis instead.

If a new device is added, then the warning level callback is called
unconditionally. Because of this, it could happen that an external
device (like a mouse) could cause the low battery mode in gsd-power to
be entered. In particular, this will result in the screen to be dimmed
very agressively.

Fixes issue #83

If we have timerfd support we will use it to wake up at the appropriate
time. There is a fallback non-timerfd path in which we wake up every
second.

The problem is that we had forgotten to ever check for timerfd support.
Add a check to the build system which enables this if timerfd_create()
exists.

Closes: #77

The udev based device manager used for wayland environments was built
based on the state of the gudev option instead of the wayland option.
This resulted in an build error when building with `-Dwayland=false`
since the gdk/gdkwayland.h header file is not present on systems without
gdk-wayland-3.0.

This patch puts the compilation of the udev based device manager behind
the wayland option and the gdk-wayland-3.0 dependency

.set() allows to set about any value (strings, integers, ...), for
strictly boolean data, .set10() seems to be a better fit