1. 20 Oct, 2021 5 commits
  2. 19 Oct, 2021 3 commits
  3. 18 Oct, 2021 2 commits
  4. 15 Oct, 2021 4 commits
    • Guido Gunther's avatar
      fbd-dev-sound: Delay sending `ended` signal · c88c6cff
      Guido Gunther authored
      Remove the feedback and the associated callback data before invoking the
      callback (which then triggers FbdFeebackBased:ended) since we otherwise
      remove the data from the currently playing sound from the hash table
      instead of removing the data from the sound that just finished playing.
      
      Call flow for a repeating sound before:
      
        on_sound_play_finished_callback()
          data->callback()
            fbd_feedback_get_ended()
              on_fb_ended()
                fbd_feedback_run()
                  g_hash_table_insert(..., feedback, data)
                  fbd_dev_sound_play()
                    gsound_context_play_full() [async]
          g_hash_table_remove (..., data->feedback) <- removes wrong feedback
      
      So (since the feedback is still the same but only the callback data
      changes) we end up removing the data from the currently playing sound
      from the hash table and any calls to fbd_dev_sound_stop() would fail
      to find data and hence not cancel the playing sound.
      
      Call flow for a repeating sound now:
      
        on_sound_play_finished_callback()
          g_hash_table_remove (..., data->feedback)
          data->callback()
            fbd_feedback_get_ended()
              on_fb_ended()
                fbd_feedback_run()
                  g_hash_table_insert(..., feedback, data)
                  fbd_dev_sound_play()
                    gsound_context_play_full() [async]
      
      So we remove the data of the currently playing sound before adding
      the feedback to the hash table again. No ownership is transfered to
      the hash table so no cleanusp need to be changed.
      
      Closes: #46
      c88c6cff
    • Guido Gunther's avatar
      fbd-dev-sounce: Name data consistently · 05bd9ae0
      Guido Gunther authored
      We name it `data` elsewhere. Don't call it `object` in one function.
      05bd9ae0
    • Guido Gunther's avatar
      fbd-dev-sound: Rename cancellable to `cancel` · 48c05be2
      Guido Gunther authored
      The current name is just confusing
      48c05be2
    • Pablo Correa Gómez's avatar
      f13c7484
  5. 14 Oct, 2021 1 commit
  6. 08 Oct, 2021 5 commits
  7. 07 Oct, 2021 1 commit
  8. 22 Sep, 2021 1 commit
  9. 06 Sep, 2021 1 commit
  10. 09 Aug, 2021 2 commits
  11. 23 Jul, 2021 4 commits
  12. 08 Jun, 2021 1 commit
  13. 31 May, 2021 2 commits
    • Andreas Hartmann's avatar
      README: Add explanation on custom theme paths · b4546808
      Andreas Hartmann authored
      The README currently states that feedbackd uses the `default.json` theme, whose
      location is hardcoded into the application. This doesn't reflect the current
      state of the code.
      
      Explain the ability to add custom themes and give some examples to the user.
      Also mention the `feedbackd-device-themes` repository explicitly for users
      looking to modify the current `default.json` theme. Adds explanations about the
      correct naming of custom theme files and theme file precedence when multiple
      themes exist.
      b4546808
    • Andreas Hartmann's avatar
      fbd-feedback-manager: Make sure theme path components are '/' separated · 1c534640
      Andreas Hartmann authored
      Previously, assembly of the theme paths for custom paths (based on
      `XDG_DATA_DIRS`) was performed using `g_strconcat`, which produced erroneous
      file paths with missing path separators due to a typo in the code.
      
      Instead, make use of `g_build_filename` to assemble the theme paths from
      `XDG_DATA_DIRS` to look for custom themes, which automatically introduces
      host-specific path separators between individual path components. This
      introduces another temporary variable to ensure that the filename (which is
      itself assembled from a name and the file ending) isn't mangled by introduction
      of a path separator between these two "parts".
      1c534640
  14. 04 May, 2021 1 commit
  15. 27 Apr, 2021 6 commits
  16. 26 Apr, 2021 1 commit