1. 22 Feb, 2022 1 commit
  2. 15 Feb, 2022 1 commit
  3. 11 Feb, 2022 4 commits
  4. 08 Feb, 2022 1 commit
  5. 04 Feb, 2022 5 commits
  6. 29 Oct, 2021 3 commits
  7. 28 Oct, 2021 1 commit
  8. 20 Oct, 2021 7 commits
  9. 19 Oct, 2021 4 commits
  10. 18 Oct, 2021 2 commits
  11. 15 Oct, 2021 4 commits
    • Guido Gunther's avatar
      fbd-dev-sound: Delay sending `ended` signal · c88c6cff
      Guido Gunther authored
      Remove the feedback and the associated callback data before invoking the
      callback (which then triggers FbdFeebackBased:ended) since we otherwise
      remove the data from the currently playing sound from the hash table
      instead of removing the data from the sound that just finished playing.
      
      Call flow for a repeating sound before:
      
        on_sound_play_finished_callback()
          data->callback()
            fbd_feedback_get_ended()
              on_fb_ended()
                fbd_feedback_run()
                  g_hash_table_insert(..., feedback, data)
                  fbd_dev_sound_play()
                    gsound_context_play_full() [async]
          g_hash_table_remove (..., data->feedback) <- removes wrong feedback
      
      So (since the feedback is still the same but only the callback data
      changes) we end up removing the data from the currently playing sound
      from the hash table and any calls to fbd_dev_sound_stop() would fail
      to find data and hence not cancel the playing sound.
      
      Call flow for a repeating sound now:
      
        on_sound_play_finished_callback()
          g_hash_table_remove (..., data->feedback)
          data->callback()
            fbd_feedback_get_ended()
              on_fb_ended()
                fbd_feedback_run()
                  g_hash_table_insert(..., feedback, data)
                  fbd_dev_sound_play()
                    gsound_context_play_full() [async]
      
      So we remove the data of the currently playing sound before adding
      the feedback to the hash table again. No ownership is transfered to
      the hash table so no cleanusp need to be changed.
      
      Closes: #46
      c88c6cff
    • Guido Gunther's avatar
      fbd-dev-sounce: Name data consistently · 05bd9ae0
      Guido Gunther authored
      We name it `data` elsewhere. Don't call it `object` in one function.
      05bd9ae0
    • Guido Gunther's avatar
      fbd-dev-sound: Rename cancellable to `cancel` · 48c05be2
      Guido Gunther authored
      The current name is just confusing
      48c05be2
    • Pablo Correa Gómez's avatar
      f13c7484
  12. 14 Oct, 2021 1 commit
  13. 08 Oct, 2021 5 commits
  14. 07 Oct, 2021 1 commit