GitLab

It is TriggerFeedback and not Feedback (anymore). Also add a note how to
end the feedback in order to prevent loss of hearing :-).

If the trigger is the last thing in sysfs_path/LED_TRIGGER_ATTR, then
the new-line at the end of the output causes g_strv_contains to fail to
find the trigger in the list. This strips the new-line before splitting
the output into a list for searching.

You can see the problem this patch fixes with the librem 5, by:

$ rmmod ledtrig-timer     # or whatever is listed at the end, so 'pattern' is the last thing
$ cat /sys/devices/platform/pwmleds/leds/blue:status/trigger
[none] kbd-scrolllock ... pattern
$ fbd-ledctrl -p /sys/devices/platform/pwmleds/leds/blue:status -t pattern
Failed to set perms of /sys/devices/platform/pwmleds/leds/blue:status/pattern to 101: No such file or directory
$ modprobe ledtrig-timer
$ cat /sys/devices/platform/pwmleds/leds/blue:status/trigger
[none] kbd-scrolllock ... pattern timer
$ fbd-ledctrl -p /sys/devices/platform/pwmleds/leds/blue:status -t pattern
<success>

Don't leak the error values in the success case

This is not an error per se.

tracks the FdbFeedbackSounds in a GHashTable in the FdbDevSound

It was off in several places. Now that there's no outstanding
MRs clean it up via

   uncrustify --replace -c phosh.cfg src/fbd-feedback-manager.c

Reads the compatible list of the device and tries to find a device-specific theme file in all  directories. If no configuration is found, we fall back to a default theme file. The device-specific theme file can always be overriden by specifying the FEEDBACK_THEME environment variable

Run a script as a post install to make sure that all GLib schemas are compiled

The foreach loop was not used to validate all the include theme files

Use a separate group for users that should be able to access
the LED devices.

The names changed in device tree which tickles up into userspace.

The fbd_dev_led_set_brightness function is only getting called with
parameter 0 at the moment so this was never noticed.

This allow us to get debs quicker

This allows pa to cork, duck, etc.

This is not a critical since we prevented submitting initially
but daemon cleanup processes all entries in the theme.

This plugs a leak.

Instead of freeing each elemnt after each iteration and then the list
itself at the very end just fully free the list. g_autoslist does
not work well on oder glib so do that manually.

This is just cosmetics.

This allows to reuse the feedback handler and we check the
reason in the actual test function anyway.

We tell the caller so debug level is enough

This avoids criticals when there's sound device available. We
can also be more precise about the reason why feedback ended.

This avoids criticals when there's no periodic vibra available.

This avoids criticals when there's no rumble vibra available.

This avoids criticals when there's no Leds available.

If we don't find any usable feedbacks for an event return
FBD_EVENT_END_REASON_NOT_FOUND.

This allows to check if a feedback type is available
at all.

This is quite common so don't fill the logs at normal debug levels
but be more specific about what is missing.

Failing to do so will always select the first recognized LED (the blue 
one for the PinePhone).