1. 07 Aug, 2019 18 commits
  2. 29 Jul, 2019 1 commit
  3. 25 Jul, 2019 3 commits
  4. 09 Jul, 2019 1 commit
  5. 01 Jun, 2019 1 commit
  6. 30 May, 2019 1 commit
  7. 18 Apr, 2019 1 commit
  8. 08 Apr, 2019 1 commit
  9. 26 Feb, 2019 1 commit
    • Niels De Graef's avatar
      ContactEditor: Don't show the "Linked Accounts" button · 60e8e80d
      Niels De Graef authored
      By executing `show_all()` on the whole ContactEditor, we show elements
      again that we explicitly set to be invisible -for example the "Linked
      Accounts" button which should not be shown for newly created contacts.
      
      We should avoid show_all() as much as possible, but to refrain from
      having large changes this late in the schedule, let's just call the
      `show_all()` on the container grid, which does not have elements that
      shouldn't be shown.
      
      Reported in https://gitlab.gnome.org/GNOME/gnome-contacts/issues/124
      60e8e80d
  10. 25 Feb, 2019 1 commit
  11. 16 Feb, 2019 1 commit
  12. 31 Jan, 2019 2 commits
  13. 29 Jan, 2019 1 commit
  14. 16 Jan, 2019 2 commits
  15. 24 Dec, 2018 1 commit
  16. 17 Dec, 2018 1 commit
    • Niels De Graef's avatar
      TypeCombo: simplify and document · 824c4c85
      Niels De Graef authored
      Remove all the code for a custom user-defined label (using an entry).
      This code path has been dead for a while, and it's better to use the
      built-in entry of a ComboBox anyway. This way, we can alo reintroduce it
      later.
      
      We can now also derive directly from a Gtk.ComboBox, which simplifies
      the code even further.
      
      Finally, this commit adds some documentation in the TypeCmbo, which
      hopefully makes it easier to understand for new contributors.
      824c4c85
  17. 16 Dec, 2018 2 commits
    • Niels De Graef's avatar
      TypeSet: fix a regression from the previous commit · 43e298a3
      Niels De Graef authored
      In some cases, a null-TypeDescriptor could be returned, spawning a
      g_critical() in the ContactSheet. Also, the VcardTypMapping.matches
      function didn't always correctly return the right value.
      43e298a3
    • Niels De Graef's avatar
      Types: decouple TypeSet and TypeDescriptor · e9998468
      Niels De Graef authored
      We completely decouple TypeSet and TypeDescriptor and expose the former
      as a public class, so we can use it from outside. This means we don't
      necessarily need to fiddle with TreeIters if we know what we need from
      the TypeDescriptor. We also slit up VCardTypeMapping in a separate file,
      and put all the logic whether something matches or not as methods of
      that struct.
      
      This commit cleans up a lot of the mess in TypeSet. I'm afraid that
      means it's quite a large diff, but from now on, the code should be more
      decoupled than before, making changes at the very least bearable.
      
      There's also some more debug statements, which should help in case
      something goes wrong when running at one of our users.
      e9998468
  18. 13 Dec, 2018 1 commit