Make mobile adjustments toggleable
Fixes https://source.puri.sm/Librem5/gtk/-/issues/23
Todo:
- Update scroll deceleration
- Update GtkFileChooserDialog
/cc @guido.gunther @adrien.plazas @sebastian.krzyszkowiak
Do gsettings set org.gtk.Settings.Purism is-phone true|false
to toggle`
Merge request reports
Activity
@mohammed.sadiq i did not test but this looks great to get rid of the forked GTK for byzantium!
- Resolved by Alice Mikhaylenko
I wonder how well this would work if we want to introduce more mobile tweaks, e.g. making the file chooser more mobile friendly by porting widgets from libhandy 1.
Since we target PureOS byzantium with this and byzantium does not have any sloppy builds we should make this a patch against Debian's 3.24.22 GTK package at some point (same with our current adaptive patches). While at that we can also move to https://source.puri.sm/Librem5/debs . @mohammed.sadiq do you want to do this or should i prepare a repo (won't happen very soon though on my side)?
added 271 commits
-
22fe48fe...2ef7303d - 255 commits from branch
Librem5:librem5-3-24-23
- e93017e1 - Add org.gtk.Settings.Purism
- 9254e87e - gtkprivate: Add an API to check if phone
- 1073e2c1 - window: Maximize window only if on phone
- 80f29d22 - dialog: Maximize window if on phone
- 7394332c - messagedialog: Set orientation based on device
- 293eeeda - fontchooserwidget: Set widget size based on the device
- 9490c796 - headerbar: Set UI based on the device
- cb21eb23 - infobar: Set UI based on the device
- c080853a - aboutdialog: Set UI based on the device
- c7064c21 - scrolledwindow: Set deceleration value based on the device
- b073c557 - filechooserdialog: Use headerbar entry depending on the device
- fc6efcb7 - tmp
- e5cb9323 - filechooserwidget: Only expand internal entry and only on mobile
- c2c81313 - fixup! tmp
- 922ddc37 - filechooserwidget: Set UI based on the device
- 925164b3 - placesview: Set UI based on the device
Toggle commit list-
22fe48fe...2ef7303d - 255 commits from branch
marked as a Work In Progress from mohammed.sadiq/gtk@c2c81313
- Resolved by Alice Mikhaylenko
Rebased for 3.24.23, made deceleration and file chooser tweaks toggleable as well.
Two exceptions that are currently different on desktop from stock GTK:
I adjusted some of the commits so that they can be lated applied as fixups to the original ones and reduce their diff as much as possible.
Edited by Alice Mikhaylenko
- Resolved by Alice Mikhaylenko
Note:
GtkFileChooserWidget
does not currently use a leaflet/flap. It uses the original paned on desktop, and creates an overlay and reparents both panes to it for mobile.
mentioned in merge request !21 (merged)
Wouldn't it be better to have this released and then reiterate from there? Phosh will toggle this setting (as other settings like the close button) anyway so until all the rest is in place this would already help convergence a lot and using the setting can then be dropped step by step - currently we don't have anything workable for large screens - which blocks both byzantium and convergence. So i'd propose
- use this
- unsloppify so we can use on byzantium
- replace by adpative code step by step
added 23 commits
- f2ed75f4 - Add GtkHdySqueezer
- 5ee53560 - Add GtkHdyViewSwitcherTitle
- bc67e4e8 - Add padding for HdyViewSwitcherTitle
- 0230d49f - Add GtkHdyShadowHelper
- 82e528bb - Add GtkHdyNavigationDirection
- 730e6267 - Add GtkHdySwipeable and GtkHdySwipeTracker
- 28f6a0b6 - Add GtkHdyStackableBox
- 34094815 - Add GtkHdyLeaflet
- ac4b70b9 - Add HdyLeaflet styles
- 834d0370 - Add GtkHdyClamp
- 3288aca6 - Add org.gtk.Settings.Purism
- e18f1a9d - gtkprivate: Add an API to check if phone
- a5bec64b - aboutdialog: Set UI based on the device
- 0c4a4703 - fontchooserwidget: Make adaptive
- e197bb55 - filechooserdialog: Reduce the number of changes for setting the entry
- 6781e47b - filechooserwidget: Make adaptive
- c42217ce - placesview: Reduce the number of changes
- 74acfb3d - window: Maximize window only if on phone
- 19ba4660 - dialog: Maximize window if on phone
- a84baf6e - messagedialog: Set orientation based on device
- f6260934 - headerbar: Set UI based on the device
- 23b5ee14 - infobar: Set UI based on the device
- 819fd787 - scrolledwindow: Set deceleration value based on the device
Toggle commit list- Resolved by Guido Gunther
Ping? :)
mentioned in commit 0d1b0431