libhandy merge requestshttps://source.puri.sm/Librem5/libhandy/-/merge_requests2018-09-11T15:03:02Zhttps://source.puri.sm/Librem5/libhandy/-/merge_requests/102leaflet: Start the child transition only when folded2018-09-11T15:03:02ZAdrien Plazasleaflet: Start the child transition only when foldedThis avoids starting the transition when unfolded, which doesn't make
sense as all children are visible.
https://source.puri.sm/Librem5/libhandy/issues/35This avoids starting the transition when unfolded, which doesn't make
sense as all children are visible.
https://source.puri.sm/Librem5/libhandy/issues/35https://source.puri.sm/Librem5/libhandy/-/merge_requests/101example: Use separators to separate the panels2018-09-10T07:28:43ZAdrien Plazasexample: Use separators to separate the panelsUse a GtkSeparator to separate the stack sidebar from the various demo
widgets, use custom styling to make the sidebar not draw its own
separator, and move the start of the header bar and the header bar
separator out of their box and dir...Use a GtkSeparator to separate the stack sidebar from the various demo
widgets, use custom styling to make the sidebar not draw its own
separator, and move the start of the header bar and the header bar
separator out of their box and directly into the leaflet.
This allows to have the separators well aligned with no workaround other
than a simple custom style, to have no separator appearing when the
window is folded, and to not trigger the GTK+ bug making titlebar
separators appear black.https://source.puri.sm/Librem5/libhandy/-/merge_requests/100column: Add the linear-growth-width property2018-09-12T11:41:53ZAdrien Plazascolumn: Add the linear-growth-width propertyThis allows the child to be allocated all the width up to a certain
point.
https://source.puri.sm/Librem5/libhandy/issues/34This allows the child to be allocated all the width up to a certain
point.
https://source.puri.sm/Librem5/libhandy/issues/34https://source.puri.sm/Librem5/libhandy/-/merge_requests/99leaflet: Hide children on transition end only when folded2018-08-29T14:32:27ZAdrien Plazasleaflet: Hide children on transition end only when foldedHides the last visible child at the end of an animation only if the
leaflet is folded. This avoids children to become incorrectly invisible
at the end of the transition when the leaflet is unfolded.
https://source.puri.sm/Librem5/libhan...Hides the last visible child at the end of an animation only if the
leaflet is folded. This avoids children to become incorrectly invisible
at the end of the transition when the leaflet is unfolded.
https://source.puri.sm/Librem5/libhandy/issues/32https://source.puri.sm/Librem5/libhandy/-/merge_requests/98leaflet: Init mode transition positions to the final values2018-08-30T10:16:28ZAdrien Plazasleaflet: Init mode transition positions to the final valuesSet the target and current mode transition positions to the final 1.0
value instead of the initial 0.0 one.
This fixes an inconsistency on initially unfolded leaflets as they would
be drawn in their folded state with no animation trigge...Set the target and current mode transition positions to the final 1.0
value instead of the initial 0.0 one.
This fixes an inconsistency on initially unfolded leaflets as they would
be drawn in their folded state with no animation triggered to transition
to the final state as the target and the current values were the same.https://source.puri.sm/Librem5/libhandy/-/merge_requests/97leaflet: initialize a variable2018-08-10T10:41:29ZJordan Petridisleaflet: initialize a variablewhile trying to compile libhandy, I bumped into a gcc warning.
```sh
[22/34] Compiling C object 'src/src@@handy-0.0@sha/hdy-leaflet.c.o'.
../src/hdy-leaflet.c: In function ‘hdy_leaflet_size_allocate’:
../src/hdy-leaflet.c:1488:16: ...while trying to compile libhandy, I bumped into a gcc warning.
```sh
[22/34] Compiling C object 'src/src@@handy-0.0@sha/hdy-leaflet.c.o'.
../src/hdy-leaflet.c: In function ‘hdy_leaflet_size_allocate’:
../src/hdy-leaflet.c:1488:16: warning: ‘max_child_size’ may be used uninitialized in this function [-Wmaybe-uninitialized]
end_size += orientation == GTK_ORIENTATION_HORIZONTAL ?
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(box_homogeneous ? max_child_size : child_info->nat.width) :
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(box_homogeneous ? max_child_size : child_info->nat.height);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hdy-leaflet.c:1390:8: note: ‘max_child_size’ was declared here
gint max_child_size;
^~~~~~~~~~~~~~
```
I think this takes care of it, it moves the initialization of `max_child_state` in the scope of the `case` statement, as opposed to the `if` branch
cc @adrien.plazashttps://source.puri.sm/Librem5/libhandy/-/merge_requests/96Add issue template2018-08-10T16:42:34ZHeather EllsworthAdd issue templateEnables a template to be in place asking (hopefully) all of the relevant questions to the submitter of the issue.
The need for bug templates came about because of developer.puri.sm!41Enables a template to be in place asking (hopefully) all of the relevant questions to the submitter of the issue.
The need for bug templates came about because of developer.puri.sm!41https://source.puri.sm/Librem5/libhandy/-/merge_requests/95Use compiler warnings from phosh2018-08-09T07:58:42ZGuido GuntherUse compiler warnings from phoshThis would have spotted
https://source.puri.sm/Librem5/libhandy/merge_requests/94
The other warnings found are harmless but make the code look better.This would have spotted
https://source.puri.sm/Librem5/libhandy/merge_requests/94
The other warnings found are harmless but make the code look better.https://source.puri.sm/Librem5/libhandy/-/merge_requests/94column: Add a missing break statement2018-08-09T07:31:33ZAdrien Plazascolumn: Add a missing break statementThis avoids falling into the default error case when getting a column's
maximum width.This avoids falling into the default error case when getting a column's
maximum width.https://source.puri.sm/Librem5/libhandy/-/merge_requests/93Test flatpak build2020-01-22T12:36:59ZGuido GuntherTest flatpak build~~This is WIP since our current unprivileted gitlab-runner isn't able to build flatpaks. The has to be fixed on an infrastructure level.~~~~This is WIP since our current unprivileted gitlab-runner isn't able to build flatpaks. The has to be fixed on an infrastructure level.~~https://source.puri.sm/Librem5/libhandy/-/merge_requests/92flatpak: Switch the runtime of the example to master2018-08-06T06:45:23ZAdrien Plazasflatpak: Switch the runtime of the example to masterLet's not live in the past: we want to test for the future. This also
avoid our users to install an old runtime when they may already have
master installed.Let's not live in the past: we want to test for the future. This also
avoid our users to install an old runtime when they may already have
master installed.https://source.puri.sm/Librem5/libhandy/-/merge_requests/91glade: Fix the generic name of HdyArrows2018-07-27T07:16:32ZAdrien Plazasglade: Fix the generic name of HdyArrowshttps://source.puri.sm/Librem5/libhandy/-/merge_requests/90Add HdyColumn to libhandy.xml2018-07-27T07:18:03ZChristopher DavisAdd HdyColumn to libhandy.xmlHdyColumn was previously missing from libhandy.xml, meaning that
it could not be used or previewed from Glade. This commit adds
HdyColumn to the file.
Fixes https://source.puri.sm/Librem5/libhandy/issues/16HdyColumn was previously missing from libhandy.xml, meaning that
it could not be used or previewed from Glade. This commit adds
HdyColumn to the file.
Fixes https://source.puri.sm/Librem5/libhandy/issues/16https://source.puri.sm/Librem5/libhandy/-/merge_requests/89example: Move the separator between the header bars2018-08-29T18:13:47ZAdrien Plazasexample: Move the separator between the header barsWhen a separator is between two header bars it will take a special
style, better fitting its purpose. This moves the start header bar and
the separator following it into a box so they remain a single entity to
use in size groups, whil...When a separator is between two header bars it will take a special
style, better fitting its purpose. This moves the start header bar and
the separator following it into a box so they remain a single entity to
use in size groups, while making the separator a sibling of the header
bar to benefit from this special style.
This supersedes https://source.puri.sm/Librem5/libhandy/merge_requests/88.https://source.puri.sm/Librem5/libhandy/-/merge_requests/88WIP: CSS border split2018-07-24T08:53:30ZAdrien PlazasWIP: CSS border splitUse custom CSS styling to split the header bars in the example.Use custom CSS styling to split the header bars in the example.https://source.puri.sm/Librem5/libhandy/-/merge_requests/87WIP: Prepare the port to GTK+ 42018-11-07T16:51:00ZAdrien PlazasWIP: Prepare the port to GTK+ 4Starts implementing the new behaviors of GTK+ 4 into the GTK+ 3 version so transition and code sharing between the two versions can be easier.
This merge request is currently not ready to be merged as it does next to nothing, and has be...Starts implementing the new behaviors of GTK+ 4 into the GTK+ 3 version so transition and code sharing between the two versions can be easier.
This merge request is currently not ready to be merged as it does next to nothing, and has been opened for review of the overall concept.https://source.puri.sm/Librem5/libhandy/-/merge_requests/86Fails builds on warnings and warn on possibly uninitialized variables2018-07-23T08:02:56ZGuido GuntherFails builds on warnings and warn on possibly uninitialized variables@adrien.plazas please look at the third patch. At least one of them looks like a real omission which I've so far just pampered over.@adrien.plazas please look at the third patch. At least one of them looks like a real omission which I've so far just pampered over.https://source.puri.sm/Librem5/libhandy/-/merge_requests/85DialerButton: Only free letter string when non-NULL2018-07-18T13:47:26ZBob HamDialerButton: Only free letter string when non-NULLJust noticed this through inspectionJust noticed this through inspectionhttps://source.puri.sm/Librem5/libhandy/-/merge_requests/84HdyButton: Chain up to parent on finalize2018-07-18T13:36:13ZGuido GuntherHdyButton: Chain up to parent on finalizehttps://source.puri.sm/Librem5/libhandy/-/merge_requests/83DialerButton: free letters2018-07-18T11:06:45ZGuido GuntherDialerButton: free lettersFound via phosh's valgrind runsFound via phosh's valgrind runs