Commit 8b2ded1c authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Jens Axboe

block: don't warn when doing fsync on read-only devices

It is possible to call fsync on a read-only handle (for example, fsck.ext2
does it when doing read-only check), and this call results in kernel

The patch b089cfd9 ("block: don't warn for flush on read-only device")
attempted to disable the warning, but it is buggy and it doesn't
(op_is_flush tests flags, but bio_op strips off the flags).
Signed-off-by: default avatarMikulas Patocka <>
Fixes: 721c7fc7 ("block: fail op_is_write() requests to read-only partitions")
Cc:	# 4.18
Signed-off-by: default avatarJens Axboe <>
parent bc811f05
......@@ -2163,9 +2163,12 @@ static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part)
const int op = bio_op(bio);
if (part->policy && (op_is_write(op) && !op_is_flush(op))) {
if (part->policy && op_is_write(op)) {
if (op_is_flush(bio->bi_opf) && !bio_sectors(bio))
return false;
"generic_make_request: Trying to write "
"to read-only block-device %s (partno %d)\n",
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment