Commit 1416270f authored by John Stultz's avatar John Stultz

selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress

In the past we've warned when ADJ_OFFSET was in progress, usually
caused by ntpd or some other time adjusting daemon running in non
steady sate, which can cause the skew calculations to be

Thus, this patch checks to see if the clock was being adjusted
when we fail so that we don't cause false negatives.

Cc: Thomas Gleixner <>
Cc: Ingo Molnar <>
Cc: Miroslav Lichvar <>
Cc: Richard Cochran <>
Cc: Prarit Bhargava <>
Cc: Stephen Boyd <>
Cc: Shuah Khan <>
Suggested-by: default avatarMiroslav Lichvar <>
Signed-off-by: default avatarJohn Stultz <>
v2: Widened the checks to look for other clock adjustments that
    could happen, as suggested by Miroslav
v3: Fixed up commit message
parent 021c9179
......@@ -134,6 +134,11 @@ int main(int argv, char **argc)
printf(" %lld.%i(act)", ppm/1000, abs((int)(ppm%1000)));
if (llabs(eppm - ppm) > 1000) {
if (tx1.offset || tx2.offset ||
tx1.freq != tx2.freq || tx1.tick != tx2.tick) {
printf(" [SKIP]\n");
return ksft_exit_skip("The clock was adjusted externally. Shutdown NTPd or other time sync daemons\n");
printf(" [FAILED]\n");
return ksft_exit_fail();
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment