Commit c0e656b7 authored by Mathias Krause's avatar Mathias Krause Committed by Herbert Xu

padata: Fix wrong usage of rcu_dereference()

A kernel with enabled lockdep complains about the wrong usage of
rcu_dereference() under a rcu_read_lock_bh() protected region.

  ===============================
  [ INFO: suspicious RCU usage. ]
  3.13.0-rc1+ #126 Not tainted
  -------------------------------
  linux/kernel/padata.c:115 suspicious rcu_dereference_check() usage!

  other info that might help us debug this:

  rcu_scheduler_active = 1, debug_locks = 1
  1 lock held by cryptomgr_test/153:
   #0:  (rcu_read_lock_bh){.+....}, at: [<ffffffff8115c235>] padata_do_parallel+0x5/0x270

Fix that by using rcu_dereference_bh() instead.
Signed-off-by: 's avatarMathias Krause <minipli@googlemail.com>
Acked-by: 's avatarSteffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: 's avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3110e400
...@@ -112,7 +112,7 @@ int padata_do_parallel(struct padata_instance *pinst, ...@@ -112,7 +112,7 @@ int padata_do_parallel(struct padata_instance *pinst,
rcu_read_lock_bh(); rcu_read_lock_bh();
pd = rcu_dereference(pinst->pd); pd = rcu_dereference_bh(pinst->pd);
err = -EINVAL; err = -EINVAL;
if (!(pinst->flags & PADATA_INIT) || pinst->flags & PADATA_INVALID) if (!(pinst->flags & PADATA_INIT) || pinst->flags & PADATA_INVALID)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment