Commit f40d90dd authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

rcutorture: Use monotonic timestamp for stall detection

[ Upstream commit 622be33f ]

The get_seconds() call is deprecated because it overflows on 32-bit
architectures. The algorithm in rcu_torture_stall() can deal with
the overflow, but another problem here is that using a CLOCK_REALTIME
stamp can lead to a false-positive stall warning when a settimeofday()
happens concurrently.

Using ktime_get_seconds() instead avoids those issues and will never
overflow. The added cast to 'unsigned long' however is necessary to
make ULONG_CMP_LT() work correctly.
Signed-off-by: 's avatarArnd Bergmann <>
Signed-off-by: 's avatarPaul E. McKenney <>
Signed-off-by: 's avatarSasha Levin <>
Signed-off-by: 's avatarGreg Kroah-Hartman <>
parent 7961182a
......@@ -1446,7 +1446,7 @@ static int rcu_torture_stall(void *args)
VERBOSE_TOROUT_STRING("rcu_torture_stall end holdoff");
if (!kthread_should_stop()) {
stop_at = get_seconds() + stall_cpu;
stop_at = ktime_get_seconds() + stall_cpu;
/* RCU CPU stall is expected behavior in following code. */
if (stall_cpu_irqsoff)
......@@ -1455,7 +1455,8 @@ static int rcu_torture_stall(void *args)
pr_alert("rcu_torture_stall start on CPU %d.\n",
while (ULONG_CMP_LT(get_seconds(), stop_at))
while (ULONG_CMP_LT((unsigned long)ktime_get_seconds(),
continue; /* Induce RCU CPU stall warning. */
if (stall_cpu_irqsoff)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment