Skip to content
  • Borislav Petkov's avatar
    x86/boot/32: Flip the logic in test_wp_bit() · 952a6c2c
    Borislav Petkov authored
    
    
    ... to have a natural "likely()" in the code flow and thus have the
    success case with a branch 99.999% of the times non-taken and function
    return code following it instead of jumping to it each time.
    
    This puts the panic() call at the end of the function - it is going to
    be practically unreachable anyway.
    
    The C code is a bit more readable too.
    
    No functionality change.
    
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: boris.ostrovsky@oracle.com
    Cc: jgross@suse.com
    Cc: thgarnie@google.com
    Link: http://lkml.kernel.org/r/20170330080101.ywsf5rg6ilzu4itk@pd.tnic
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    952a6c2c