Skip to content
  • Eric W. Biederman's avatar
    fs: Call d_automount with the filesystems creds · aeaa4a79
    Eric W. Biederman authored
    Seth Forshee reported a mount regression in nfs autmounts
    with "fs: Add user namespace member to struct super_block".
    
    It turns out that the assumption that current->cred is something
    reasonable during mount while necessary to improve support of
    unprivileged mounts is wrong in the automount path.
    
    To fix the existing filesystems override current->cred with the
    init_cred before calling d_automount and restore current->cred after
    d_automount completes.
    
    To support unprivileged mounts would require a more nuanced cred
    selection, so fail on unprivileged mounts for the time being.  As none
    of the filesystems that currently set FS_USERNS_MOUNT implement
    d_automount this check is only good for preventing future problems.
    
    Fixes: 6e4eab57
    
     ("fs: Add user namespace member to struct super_block")
    Tested-by: default avatarSeth Forshee <seth.forshee@canonical.com>
    Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
    aeaa4a79