Skip to content
  • Chao Yu's avatar
    f2fs: enhance multithread performance · bb96a8d5
    Chao Yu authored
    
    
    In ->writepages, we use writepages mutex lock to serialize all block
    address allocation and page submitting pairs from different inodes.
    This method makes our delayed dirty pages of one inode being written
    continously as many as possible.
    
    But there is one problem that we did not submit current cached bio in
    protection region of writepages mutex lock, so there is a small chance
    that we submit the one of other thread's as below, resulting in
    splitting more bios.
    
    thread 1			thread 2
    ->writepages
      lock(writepages)
      ->write_cache_pages
      unlock(writepages)
    				  lock(writepages)
    				  ->write_cache_pages
      ->f2fs_submit_merged_bio
    				    ->writepage
    				  unlock(writepages)
    
    fs_mark-6535  [002] ....  2242.270230: f2fs_submit_write_bio: dev = (1,0), WRITE_SYNC, DATA, sector = 5766152, size = 524288
    fs_mark-6536  [000] ....  2242.270361: f2fs_submit_write_bio: dev = (1,0), WRITE_SYNC, DATA, sector = 5767176, size = 4096
    fs_mark-6536  [000] ....  2242.270370: f2fs_submit_write_bio: dev = (1,0), WRITE_SYNC, NODE, sector = 8138112, size = 4096
    fs_mark-6535  [002] ....  2242.270776: f2fs_submit_write_bio: dev = (1,0), WRITE_SYNC, DATA, sector = 5767184, size = 516096
    
    This may really increase time of block layer works, and may cause
    larger IO lantency.
    
    This patch moves the submitting operation into region of writepages
    mutex lock to avoid bio splits when concurrently writebacking is
    intensive.
    
    my test environment: virtual machine,
    intel cpu i5 2500, 8GB size memory, 4GB size ramdisk
    
    time fs_mark  -t  16  -L  1  -s  524288  -S  1  -d  /mnt/f2fs/
    
    before:
    real	0m4.244s
    user	0m0.088s
    sys	0m12.336s
    
    after:
    real	0m3.822s
    user	0m0.072s
    sys	0m10.760s
    
    Signed-off-by: default avatarChao Yu <chao2.yu@samsung.com>
    Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
    bb96a8d5