Commit 6fd94178 authored by Chengguang Xu's avatar Chengguang Xu Committed by Theodore Ts'o

ext4: cache NULL when both default_acl and acl are NULL

default_acl and acl of newly created inode will be initiated as
ACL_NOT_CACHED in vfs function inode_init_always() and later will be
updated by calling xxx_init_acl() in specific filesystems.  However,
when default_acl and acl are NULL then they keep the value of
ACL_NOT_CACHED.  This patch changes the code to cache NULL for acl /
default_acl in this case to save unnecessary ACL lookup attempt.
Signed-off-by: default avatarChengguang Xu <>
Signed-off-by: default avatarTheodore Ts'o <>
Reviewed-by: default avatarJan Kara <>
parent 8a98ec7c
......@@ -284,12 +284,16 @@ ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
error = __ext4_set_acl(handle, inode, ACL_TYPE_DEFAULT,
default_acl, XATTR_CREATE);
} else {
inode->i_default_acl = NULL;
if (acl) {
if (!error)
error = __ext4_set_acl(handle, inode, ACL_TYPE_ACCESS,
} else {
inode->i_acl = NULL;
return error;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment