Commit c0a37d48 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Theodore Ts'o

ext4: use file_dentry()

EXT4 may be used as lower layer of overlayfs and accessing f_path.dentry
can lead to a crash.

Fix by replacing direct access of file->f_path.dentry with the
file_dentry() accessor, which will always return a native object.
Reported-by: default avatarDaniel Axtens <>
Fixes: 4bacc9c9 ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
Fixes: ff978b09 ("ext4 crypto: move context consistency check to ext4_file_open()")
Signed-off-by: default avatarMiklos Szeredi <>
Signed-off-by: default avatarTheodore Ts'o <>
Cc: David Howells <>
Cc: Al Viro <>
Cc: <> # v4.5
parent 9dd78d8c
......@@ -374,7 +374,7 @@ static int ext4_file_open(struct inode * inode, struct file * filp)
return -ENOKEY;
dir = dget_parent(filp->f_path.dentry);
dir = dget_parent(file_dentry(filp));
if (ext4_encrypted_inode(d_inode(dir)) &&
!ext4_is_child_context_consistent_with_parent(d_inode(dir), inode)) {
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment