Verified Commit e6354349 authored by Sebastian Krzyszkowiak's avatar Sebastian Krzyszkowiak
Browse files

s5k3l6xx: Set noise reduction register to 0x0977 for all modes

Having it at 0x0974 makes the upper half of analog gain values
act badly (best noticeable under indoor light).
parent aabf9fce
Pipeline #69116 passed with stage
in 63 minutes and 2 seconds
......@@ -122,10 +122,8 @@ static const struct s5k3l6xx_reg frame_1052x780px_8bit_xfps_2lane[] = {
// Noise reduction
// The last 3 bits (0x0007) control some global brightness/noise pattern.
// They work slightly differently depending on the value of 307b:80
// It's not strictly necessary here,
// as the sensor seems to do the same correction without asking at 1:4 binning,
// but added to formalize the default value.
{ 0x3074, 0x0974, 2},
// Lower values seem to make analog gain behave in a non-linear way.
{ 0x3074, 0x0977, 2},
};
// Downscaled 1:2 in both directions.
......@@ -167,7 +165,8 @@ static const struct s5k3l6xx_reg frame_2104x1560px_8bit_xfps_2lane[] = {
// The last 3 bits (0x0007) control some global brightness/noise pattern.
// They work slightly differently depending on the value of 307b:80
// 0x0972 makes focus pixels appear.
{ 0x3074, 0x0974, 2}, // 74, 75, 76, 77 all good for binning 1:2.
// Lower values seem to make analog gain behave in a non-linear way.
{ 0x3074, 0x0977, 2}, // 74, 75, 76, 77 all good for binning 1:2.
// filter out autofocus pixels
// FIXME: this should be behind a custom control instead
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment