1. 05 Jul, 2021 1 commit
    • Dorota Czaplejewicz's avatar
      s5k3l6xx: Filter out focus pixels · aabf9fce
      Dorota Czaplejewicz authored
      This is a hack, a proper solution is adding a custom control. Userpace hasn't caught up yet however.
      
      It might be annoying when debugging, but then there's the override interface for this purpose already.
      aabf9fce
  2. 13 Jun, 2021 1 commit
  3. 09 Jun, 2021 1 commit
  4. 17 May, 2021 1 commit
  5. 12 May, 2021 1 commit
  6. 11 May, 2021 2 commits
  7. 07 May, 2021 1 commit
  8. 04 May, 2021 4 commits
  9. 03 May, 2021 26 commits
  10. 08 Oct, 2020 1 commit
    • Hans Verkuil's avatar
      media: s5k5baf: drop 'data' field in struct s5k5baf_fw · 7124ae48
      Hans Verkuil authored
      
      
      struct s5k5baf_fw ends with this:
      
             struct {
                     u16 id;
                     u16 offset;
             } seq[0];
             u16 data[];
      };
      
      which is rather confusing and can cause gcc warnings:
      
      s5k5baf.c: In function 's5k5baf_load_setfile.isra':
      s5k5baf.c:390:13: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct <anonymous>[0]' [-Wzero-length-bounds]
        390 |   if (f->seq[i].offset + d <= end)
            |       ~~~~~~^~~
      
      It turns out that 'data[]' is used in only one place and it can
      easily be replaced by &fw->seq[0].id and 'seq[0]' can be replaced by
      'seq[]'.
      
      This is both more readable and solved that warnings.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Cc: Kyungmin Park <kyungmin.park@samsung.com>
      Cc: Sylwester Nawrocki <snawrocki@kernel.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      7124ae48
  11. 25 May, 2020 1 commit
    • Gustavo A. R. Silva's avatar
      media: s5k5baf: Replace zero-length array with flexible-array · 142d0648
      Gustavo A. R. Silva authored
      The current codebase makes use of the zero-length array language
      extension to the C90 standard, but the preferred mechanism to declare
      variable-length types such as these ones is a flexible array member[1][2],
      introduced in C99:
      
      struct foo {
              int stuff;
              struct boo array[];
      };
      
      By making use of the mechanism above, we will get a compiler warning
      in case the flexible array does not occur last in the structure, which
      will help us prevent some kind of undefined behavior bugs from being
      inadvertently introduced[3] to the codebase from now on.
      
      Also, notice that, dynamic memory allocations won't be affected by
      this change:
      
      "Flexible array members have incomplete type, and so the sizeof operator
      may not be applied. As a quirk of the original implementation of
      zero-length arrays, sizeof evaluates to zero."[1]
      
      sizeof(flexible-array-member) triggers a warning because flexible array
      members have incomplete type[1]. There are some instances of code in
      which the sizeof operator is being incorrectly/erroneously applied to
      zero-length arrays and the result is zero. Such instances may be hiding
      some bugs. So, this work (flexible-array member conversions) will also
      help to get completely rid of those sorts of issues.
      
      This issue was found with the help of Coccinelle.
      
      [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
      [2] https://github.com/KSPP/linux/issues/21
      [3] commit 76497732
      
       ("cxgb3/l2t: Fix undefined behaviour")
      Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      142d0648