Initial Torch / Flash support

This is an initial driver for the torch/flash chip. I haven't tested the flash functionality yet but torch works (treating the two leds just as one for the moment).

TODOs (for upstream submission):

• handle leds separately (athough they're always forced to the same mode)
• support strobe gpio
• tie into v4l via v4l2_flash
• runtime pm
• describe bindings

But i think this should be good enough initially to help librem5-apps/librem5-goodies!12 (closed)

Testing

for i in `seq 1 8` 0; do echo $i > /sys/class/leds/white\:torch/brightness; sleep 0.5 ; done

echo 1 > /sys/class/leds/white\:torch/flash_strobe ; echo 0 > /sys/class/leds/white\:torch/flash_strobe

Closes: #211 (closed)

added 3 commits

• 955d9024 - leds: Add driver for LM3560 LED controller
• ff628b96 - librem5: Enable lm3560 LED flash driver
• cd6ddf9d - arm64: dts: imx8mq-librem5: Enable lm3560 LED

Compare with previous version

added 4 commits

• 6046c9f3 - arm64: dts: imx8mq-librem5: Don't prefix I2C address with '0'
• 0066cb31 - leds: Add driver for LM3560 LED controller
• 0a8686c3 - librem5: Enable lm3560 LED flash driver
• 9e588725 - arm64: dts: imx8mq-librem5: Enable lm3560 LED

Compare with previous version

mentioned in merge request librem5-apps/librem5-goodies!12 (closed)

changed the description

resolved all threads

@guido.gunther why this driver when in the mainline tree there is CONFIG_VIDEO_LM3560 ("This is a driver for the lm3560 dual flash controllers. It controls flash, torch LEDs.")? That looks like it does what we want and just needs "of_" dts hook-ups.

changed the description

added 4 commits

• 3ab4dad4 - leds: Add driver for LM3560 LED controller
• 80ab4896 - librem5: Enable lm3560 LED flash driver
• efbd0d1e - arm64: dts: imx8mq-librem5: Enable lm3560 LED
• f92a80c3 - fixup! leds: Add driver for LM3560 LED controller

Compare with previous version

marked as a Work In Progress from guido.gunther/linux-next@f92a80c3

added 3 commits

• e9b752e5 - leds: Add driver for LM3560 LED controller
• c3086c65 - librem5: Enable lm3560 LED flash driver
• 144b443b - arm64: dts: imx8mq-librem5: Enable lm3560 LED

Compare with previous version

resolved all threads

changed the description

unmarked as a Work In Progress

unwipped this since it's works here for toggeling flash and torch.

works for me. could you add a link to the upstream discussion to https://source.puri.sm/Librem5/linux-next/-/issues/211 (and keep it open)? Since it's a nice self-contained driver IMO we can merge this.

changed the description

added 3 commits

• 30b1d39e - leds: Add driver for LM3560 LED controller
• d62b2f79 - librem5: Enable lm3560 LED flash driver
• 1e147a0a - arm64: dts: imx8mq-librem5: Enable lm3560 LED

Compare with previous version

resolved all threads

I think the current values may be too high, I've seen the LEDs blinking and turning off when playing with it a bit. You may want to take a look at discussion in https://source.puri.sm/Librem5/linux-protected/-/issues/28#note_76734