Skip to content

imx: Fix rounding values

Dorota Czaplejewicz requested to merge (removed):formats2 into pureos/byzantium

The commit message mentions 8-pixels alignment, whereas rounding is performed to 2^8. For the width, the rounding factor is 8-pixels, according to the data sheet. This indicates that the author misunderstood the round_up() semantics in the neighboring roundings too.

This fixes big camera preview in Megapixels:

  1. https://source.puri.sm/dorota.czaplejewicz/nani#debugging-info
  2. sebastian.krzyszkowiak/megapixels@a33e5d21

WIP: this is based on https://source.puri.sm/Librem5/linux-next/-/merge_requests/430 .

Edited by Dorota Czaplejewicz

Merge request reports