Skip to content
  • Finn Thain's avatar
    scsi: mac_esp: Fix PIO transfers for MESSAGE IN phase · 7640d91d
    Finn Thain authored
    
    
    When in MESSAGE IN phase, the ESP device does not automatically
    acknowledge each byte that is transferred by PIO. The mac_esp driver
    neglects to explicitly ack them, which causes a timeout during messages
    larger than one byte (e.g. tag bytes during reconnect). Fix this with an
    ESP_CMD_MOK command after each byte.
    
    The MESSAGE IN phase is also different in that each byte transferred
    raises ESP_INTR_FDONE. So don't exit the transfer loop for this interrupt,
    for this phase.
    
    That resolves the "Reconnect IRQ2 timeout" error on those Macs which use
    PIO transfers instead of PDMA. This patch also improves on the weak tests
    for unexpected interrupts and phase changes during PIO transfers.
    
    Tested-by: default avatarStan Johnson <userm57@yahoo.com>
    Fixes: 02507a80
    
     ("[PATCH] [SCSI] mac_esp: fix PIO mode, take 2")
    Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    7640d91d