Skip to content
  • Fredrik Noring's avatar
    usb: host: Fix excessive alignment restriction for local memory allocations · ff2437be
    Fredrik Noring authored
    
    
    The PAGE_SHIFT alignment restriction to devm_gen_pool_create() quickly
    exhaust local memory because most allocations are much smaller than
    PAGE_SIZE. This causes USB device failures such as
    
    	usb 1-2.1: reset full-speed USB device number 4 using sm501-usb
    	sd 1:0:0:0: [sda] tag#0 UNKNOWN(0x2003) Result: hostbyte=0x03 driverbyte=0x00
    	sd 1:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 08 7c 00 00 f0 00
    	print_req_error: I/O error, dev sda, sector 2172 flags 80700
    
    when trying to boot from the SM501 USB controller on SH4 with QEMU.
    
    Align allocations as required but not necessarily much more than that.
    The HCCA, TD and ED structures align with 256, 32 and 16 byte memory
    boundaries, as specified by the Open HCI[1]. The min_alloc_order argument
    to devm_gen_pool_create is now somewhat arbitrarily set to 4 (16 bytes).
    Perhaps it could be somewhat lower for general buffer allocations.
    
    Reference:
    
    [1] "Open Host Controller Interface Specification for USB",
        release 1.0a, Compaq, Microsoft, National Semiconductor, 1999,
        pp. 16, 19, 33.
    
    Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarFredrik Noring <noring@nocrew.org>
    Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    ff2437be