Skip to content
  • Masahiro Yamada's avatar
    kbuild: do not create wrappers for header-test-y · c93a0368
    Masahiro Yamada authored
    header-test-y does not work with headers in sub-directories.
    
    For example, you may want to write a Makefile, like this:
    
    include/linux/Kbuild:
    
      header-test-y += mtd/nand.h
    
    This entry will create a wrapper include/linux/mtd/nand.hdrtest.c
    with the following content:
    
      #include "mtd/nand.h"
    
    To make this work, we need to add $(srctree)/include/linux to the
    header search path. It would be tedious to add ccflags-y.
    
    Instead, we could change the *.hdrtest.c rule to wrap:
    
      #include "nand.h"
    
    This works for in-tree build since #include "..." searches in the
    relative path from the header with this directive. For O=... build,
    we need to add $(srctree)/include/linux/mtd to the header search path,
    which will be even more tedious.
    
    After all, I thought it would be handier to compile headers directly
    without creating wrappers.
    
    I added a new build rule to compile %.h into %.h.s
    
    The target is %.h.s instead of %.h.o because it is slightly faster.
    Also, as for GCC, an empty assembly is smaller than an empty object.
    
    I wrote the build rule:
    
      $(CC) $(c_flags) -S -o $@ -x c /dev/null -include $<
    
    instead of:
    
      $(CC) $(c_flags) -S -o $@ -x c $<
    
    Both work fine with GCC, but the latter is bad for Clang.
    
    This comes down to the difference in the -Wunused-function policy.
    GCC does not warn about unused 'static inline' functions at all.
    Clang does not warn about the ones in included headers, but does
    about the ones in the source. So, we should handle headers as
    headers, not as source files.
    
    In fact, this has been hidden since commit abb2ea7d
    
     ("compiler,
    clang: suppress warning for unused static inline functions"), but we
    should not rely on that.
    
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
    Tested-by: default avatarJani Nikula <jani.nikula@intel.com>
    c93a0368