Skip to content
  • Gustavo A. R. Silva's avatar
    mac80211: remove unnecessary NULL check · 40b5a0f8
    Gustavo A. R. Silva authored
    
    
    Both old and new cannot be NULL at the same time, hence checking
    new when old is not NULL is unnecessary.
    
    Also, notice that new is being dereferenced before it is checked:
    
    	idx = new->conf.keyidx;
    
    The above triggers a static code analysis warning.
    
    Address this by removing the NULL check on new and adding a code
    comment based on the following piece of code:
    
    387        /* caller must provide at least one old/new */
    388        if (WARN_ON(!new && !old))
    389                return 0;
    
    Addresses-Coverity-ID: 1473176 ("Dereference before null check")
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    40b5a0f8