Skip to content
  • Leslie Monis's avatar
    net: sched: pie: fix coding style issues · ac4a02c5
    Leslie Monis authored
    
    
    Fix 5 warnings and 14 checks issued by checkpatch.pl:
    
    CHECK: Logical continuations should be on the previous line
    +	if ((q->vars.qdelay < q->params.target / 2)
    +	    && (q->vars.prob < MAX_PROB / 5))
    
    WARNING: line over 80 characters
    +		q->params.tupdate = usecs_to_jiffies(nla_get_u32(tb[TCA_PIE_TUPDATE]));
    
    CHECK: Blank lines aren't necessary after an open brace '{'
    +{
    +
    
    CHECK: braces {} should be used on all arms of this statement
    +			if (qlen < QUEUE_THRESHOLD)
    [...]
    +			else {
    [...]
    
    CHECK: Unbalanced braces around else statement
    +			else {
    
    CHECK: No space is necessary after a cast
    +	if (delta > (s32) (MAX_PROB / (100 / 2)) &&
    
    CHECK: Unnecessary parentheses around 'qdelay == 0'
    +	if ((qdelay == 0) && (qdelay_old == 0) && update_prob)
    
    CHECK: Unnecessary parentheses around 'qdelay_old == 0'
    +	if ((qdelay == 0) && (qdelay_old == 0) && update_prob)
    
    CHECK: Unnecessary parentheses around 'q->vars.prob == 0'
    +	if ((q->vars.qdelay < q->params.target / 2) &&
    +	    (q->vars.qdelay_old < q->params.target / 2) &&
    +	    (q->vars.prob == 0) &&
    +	    (q->vars.avg_dq_rate > 0))
    
    CHECK: Unnecessary parentheses around 'q->vars.avg_dq_rate > 0'
    +	if ((q->vars.qdelay < q->params.target / 2) &&
    +	    (q->vars.qdelay_old < q->params.target / 2) &&
    +	    (q->vars.prob == 0) &&
    +	    (q->vars.avg_dq_rate > 0))
    
    CHECK: Blank lines aren't necessary before a close brace '}'
    +
    +}
    
    CHECK: Comparison to NULL could be written "!opts"
    +	if (opts == NULL)
    
    CHECK: No space is necessary after a cast
    +			((u32) PSCHED_TICKS2NS(q->params.target)) /
    
    WARNING: line over 80 characters
    +	    nla_put_u32(skb, TCA_PIE_TUPDATE, jiffies_to_usecs(q->params.tupdate)) ||
    
    CHECK: Blank lines aren't necessary before a close brace '}'
    +
    +}
    
    CHECK: No space is necessary after a cast
    +		.delay		= ((u32) PSCHED_TICKS2NS(q->vars.qdelay)) /
    
    WARNING: Missing a blank line after declarations
    +	struct sk_buff *skb;
    +	skb = qdisc_dequeue_head(sch);
    
    WARNING: Missing a blank line after declarations
    +	struct pie_sched_data *q = qdisc_priv(sch);
    +	qdisc_reset_queue(sch);
    
    WARNING: Missing a blank line after declarations
    +	struct pie_sched_data *q = qdisc_priv(sch);
    +	q->params.tupdate = 0;
    
    Signed-off-by: default avatarLeslie Monis <lesliemonis@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ac4a02c5