Skip to content
  • Vivek Goyal's avatar
    vfs: Use upper filesystem inode in bprm_fill_uid() · fea6d2a6
    Vivek Goyal authored
    
    
    Right now bprm_fill_uid() uses inode fetched from file_inode(bprm->file).
    This in turn returns inode of lower filesystem (in a stacked filesystem
    setup).
    
    I was playing with modified patches of shiftfs posted by james bottomley
    and realized that through shiftfs setuid bit does not take effect. And
    reason being that we fetch uid/gid from inode of lower fs (and not from
    shiftfs inode). And that results in following checks failing.
    
    /* We ignore suid/sgid if there are no mappings for them in the ns */
    if (!kuid_has_mapping(bprm->cred->user_ns, uid) ||
        !kgid_has_mapping(bprm->cred->user_ns, gid))
    	return;
    
    uid/gid fetched from lower fs inode might not be mapped inside the user
    namespace of container. So we need to look at uid/gid fetched from
    upper filesystem (shiftfs in this particular case) and these should be
    mapped and setuid bit can take affect.
    
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
    fea6d2a6