Skip to content
  • Amitoj Kaur Chawla's avatar
    gpio: timberdale: Switch to devm_ioremap_resource() · fa283db7
    Amitoj Kaur Chawla authored
    
    
    Replace calls to devm_request_mem_region and devm_ioremap with a
    direct call to devm_ioremap_resource instead and modify error
    handling.
    
    Move the call to platform_get_resource adjacent to the call to
    devm_ioremap_resource to make the connection between them more
    clear.
    
    A simplified version of the Coccinelle semantic patch that is used to
    make this change is as follows:
    //<smpl>
    @nm@
    expression myname;
    identifier i;
    @@
    
    struct platform_driver i = { .driver = { .name = myname } };
    
    @@
    expression dev,res,size,e1,e;
    expression nm.myname;
    @@
    
    -if (!devm_request_mem_region(dev, res->start, size,
    -                              \(res->name\|dev_name(dev)\|myname\)))
                                   {
    -   ...
    -   return ...;
    -}
    ... when != res->start = e1
    e =
    -devm_ioremap(dev,res->start,size);
    +devm_ioremap_resource(dev,res);
    
    if
    -(e == NULL)
    +(IS_ERR(e))
    {
     ...
    -return ...;
    +return PTR_ERR(e);
    }
    //</smpl>
    
    Further, updated error handling by hand as devm_ioremap_resource
    gives appropriate error messages, so remove unnecessary error
    messages.
    
    Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    fa283db7