Commit 30da870c authored by Al Viro's avatar Al Viro

affs_lookup(): close a race with affs_remove_link()

we unlock the directory hash too early - if we are looking at secondary
link and primary (in another directory) gets removed just as we unlock,
we could have the old primary moved in place of the secondary, leaving
us to look into freed entry (and leaving our dentry with ->d_fsdata
pointing to a freed entry).

Cc: # 2.4.4+
Acked-by: default avatarDavid Sterba <>
Signed-off-by: default avatarAl Viro <>
parent b127125d
......@@ -206,9 +206,10 @@ affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
bh = affs_find_entry(dir, dentry);
if (IS_ERR(bh))
if (IS_ERR(bh)) {
return ERR_CAST(bh);
if (bh) {
u32 ino = bh->b_blocknr;
......@@ -222,10 +223,13 @@ affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
inode = affs_iget(sb, ino);
if (IS_ERR(inode))
if (IS_ERR(inode)) {
return ERR_CAST(inode);
d_add(dentry, inode);
return NULL;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment