Commit d3ba3ae1 authored by Baoquan He's avatar Baoquan He Committed by Linus Torvalds

mm/memory_hotplug.c: fix the wrong usage of N_HIGH_MEMORY

In node_states_check_changes_online(), N_HIGH_MEMORY is used to substitute
ZONE_HIGHMEM directly.  This is not right.  N_HIGH_MEMORY is to mark the
memory state of node.  Here zone index is checked, which should be
compared with 'ZONE_HIGHMEM' accordingly.

Replace it with ZONE_HIGHMEM.

This is a code cleanup - no known runtime effects.

Fixes: 8efe33f4 ("mm/memory_hotplug.c: simplify node_states_check_changes_online")
Signed-off-by: default avatarBaoquan He <>
Reviewed-by: default avatarDavid Hildenbrand <>
Acked-by: default avatarMichal Hocko <>
Reviewed-by: default avatarOscar Salvador <>
Cc: Wei Yang <>
Cc: Mike Rapoport <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 39186cbe
......@@ -714,7 +714,7 @@ static void node_states_check_changes_online(unsigned long nr_pages,
if (zone_idx(zone) <= ZONE_NORMAL && !node_state(nid, N_NORMAL_MEMORY))
arg->status_change_nid_normal = nid;
if (zone_idx(zone) <= N_HIGH_MEMORY && !node_state(nid, N_HIGH_MEMORY))
if (zone_idx(zone) <= ZONE_HIGHMEM && !node_state(nid, N_HIGH_MEMORY))
arg->status_change_nid_high = nid;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment