1. 21 May, 2019 1 commit
  2. 23 Jul, 2018 1 commit
  3. 16 May, 2018 1 commit
  4. 14 May, 2018 1 commit
  5. 16 Jan, 2018 11 commits
    • Finn Thain's avatar
      nubus: Add support for the driver model · 7f86c765
      Finn Thain authored
      This patch brings basic support for the Linux Driver Model to the
      NuBus subsystem.
      For flexibility, the matching of boards with drivers is left up to the
      drivers. This is also the approach taken by NetBSD. A board may have
      many functions, and drivers may have to consider many functional
      resources and board resources in order to match a device.
      This implementation does not bind drivers to resources (nor does it bind
      many drivers to the same board). Apple's NuBus declaration ROM design
      is flexible enough to allow that, but I don't see a need to support it
      as we don't use the "slot zero" resources (in the main logic board ROM).
      Eliminate the global nubus_boards linked list by rewriting the procfs
      board iterator around bus_for_each_dev(). Hence the nubus device refcount
      can be used to determine the lifespan of board objects.
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Adopt standard linked list implementation · 41b84816
      Finn Thain authored
      This increases code re-use and improves readability.
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
      Acked-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Rename struct nubus_dev · 189e19e8
      Finn Thain authored
      It is misleading to call a functional resource a "device". In adopting
      the Linux Driver Model, the struct device will be embedded in struct
      nubus_board. That will compound the terminlogy problem because drivers
      will bind with boards, not with functional resources. Avoid this by
      renaming struct nubus_dev as struct nubus_rsrc. "Functional resource"
      is the vendor's terminology so this helps avoid confusion.
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
      Acked-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Rework /proc/bus/nubus/s/ implementation · 2f7dd07e
      Finn Thain authored
      The /proc/bus/nubus/s/ directory tree for any slot s is missing a lot
      of information. The struct file_operations methods have long been left
      unimplemented (hence the familiar compile-time warning, "Need to set
      some I/O handlers here").
      Slot resources have a complex structure which varies depending on board
      function. The logic for interpreting these ROM data structures is found
      in nubus.c. Let's not duplicate that logic in proc.c.
      Create the /proc/bus/nubus/s/ inodes while scanning slot s. During
      descent through slot resource subdirectories, call the new
      nubus_proc_add_foo() functions to create the procfs inodes.
      Also add a new function, nubus_seq_write_rsrc_mem(), to write the
      contents of a particular slot resource to a given seq_file. This is
      used by the procfs file_operations methods, to finally give userspace
      access to slot ROM information, such as the available video modes.
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Generalize block resource handling · 883b8cb3
      Finn Thain authored
      Scrap the specialized code to unpack video mode name resources and
      driver resources. It isn't useful.
      Instead, add a re-usable function to handle lists of block resources of
      any kind, and descend into the video mode table resource directory.
      Rename callers as nubus_get_foo(), consistent with their purpose and
      with related functions in the same file.
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Remove redundant code · 9f97977d
      Finn Thain authored
      Eliminate unused values from struct nubus_dev to save wasted memory
      (a Radius PrecisionColor 24X card has about 95 functional resources
      and up to six such cards may be fitted). Also remove redundant static
      variable initialization, an unreachable !MACH_IS_MAC conditional,
      the unused nubus_find_device() function, the bogus get_nubus_list()
      prototype and the pointless card_present temporary variable.
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Call proc_mkdir() not more than once per slot directory · 6c8b89ea
      Finn Thain authored
      This patch fixes the following WARNING.
      proc_dir_entry 'nubus/a' already registered
      Modules linked in:
      CPU: 0 PID: 1 Comm: swapper Tainted: G        W       4.13.0-00036-gd57552077387 #1
      Stack from 01c1bd9c:
              01c1bd9c 003c2c8b 01c1bdc0 0001b0fe 00000000 00322f4a 01c43a20 01c43b0c
              01c8c420 01c1bde8 0001b1b8 003a4ac3 00000148 000faa26 00000009 00000000
              01c1bde0 003a4b6c 01c1bdfc 01c1be20 000faa26 003a4ac3 00000148 003a4b6c
              01c43a71 01c8c471 01c10000 00326430 0043d00c 00000005 01c71a00 0020bce0
              00322964 01c1be38 000fac04 01c43a20 01c8c420 01c1bee0 01c8c420 01c1be50
              000fac4c 01c1bee0 00000000 01c43a20 00000000 01c1bee8 0020bd26 01c1bee0
      Call Trace: [<0001b0fe>] __warn+0xae/0xde
       [<00322f4a>] memcmp+0x0/0x5c
       [<0001b1b8>] warn_slowpath_fmt+0x2e/0x36
       [<000faa26>] proc_register+0xbe/0xd8
       [<000faa26>] proc_register+0xbe/0xd8
       [<00326430>] sprintf+0x0/0x20
       [<0020bce0>] nubus_proc_attach_device+0x0/0x1b8
       [<00322964>] strcpy+0x0/0x22
       [<000fac04>] proc_mkdir_data+0x64/0x96
       [<000fac4c>] proc_mkdir+0x16/0x1c
       [<0020bd26>] nubus_proc_attach_device+0x46/0x1b8
       [<0020bce0>] nubus_proc_attach_device+0x0/0x1b8
       [<00322964>] strcpy+0x0/0x22
       [<00001ba6>] kernel_pg_dir+0xba6/0x1000
       [<004339a2>] proc_bus_nubus_add_devices+0x1a/0x2e
       [<000faa40>] proc_create_data+0x0/0xf2
       [<0003297c>] parse_args+0x0/0x2d4
       [<00433a08>] nubus_proc_init+0x52/0x5a
       [<00433944>] nubus_init+0x0/0x44
       [<00433982>] nubus_init+0x3e/0x44
       [<000020dc>] do_one_initcall+0x38/0x196
       [<000020a4>] do_one_initcall+0x0/0x196
       [<0003297c>] parse_args+0x0/0x2d4
       [<00322964>] strcpy+0x0/0x22
       [<00040004>] __up_read+0xe/0x40
       [<004231d4>] repair_env_string+0x0/0x7a
       [<0042312e>] kernel_init_freeable+0xee/0x194
       [<00423146>] kernel_init_freeable+0x106/0x194
       [<00433944>] nubus_init+0x0/0x44
       [<000a6000>] kfree+0x0/0x156
       [<0032768c>] kernel_init+0x0/0xda
       [<00327698>] kernel_init+0xc/0xda
       [<0032768c>] kernel_init+0x0/0xda
       [<00002a90>] ret_from_kernel_thread+0xc/0x14
      ---[ end trace 14a6d619908ea253 ]---
      ------------[ cut here ]------------
      This gets repeated with each additional functional reasource.
      The problem here is the call to proc_mkdir() when the directory already
      exists. Each nubus_board gets a directory, such as /proc/bus/nubus/s/
      where s is the hex slot number. Therefore, store the 'procdir' pointer
      in struct nubus_board instead of struct nubus_dev.
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Validate slot resource IDs · d7811a36
      Finn Thain authored
      While we are here, include the slot number in the related error messages.
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Fix log spam · f53bad08
      Finn Thain authored
      Testing shows that a single Radius PrecisionColor 24X display board,
      which has 95 functional resources, produces over a thousand lines of
      log messages. Suppress these messages with pr_debug().
      Remove some redundant messages relating to nubus_get_subdir() calls.
      Fix the format block debug messages as the sequence of entries is
      backwards (my bad).
      Move the "scanning slots" message to its proper location.
      Fixes: 71ae40e4 ("nubus: Clean up printk calls")
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Use static functions where possible · 460cf95e
      Finn Thain authored
      This fixes a couple of warnings from 'make W=1':
      drivers/nubus/nubus.c:790: warning: no previous prototype for 'nubus_probe_slot'
      drivers/nubus/nubus.c:824: warning: no previous prototype for 'nubus_scan_bus'
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    • Finn Thain's avatar
      nubus: Avoid array underflow and overflow · 2f828fb2
      Finn Thain authored
      Check array indices. Avoid sprintf. Use buffers of sufficient size.
      Use appropriate types for array length parameters.
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
  6. 09 Nov, 2017 1 commit
    • Finn Thain's avatar
      m68k/mac: Disentangle VIA/RBV and NuBus initialization · 8ee90c5c
      Finn Thain authored
      The Nubus subsystem should not be concerned with differences between VIA,
      RBV and OSS platforms. It should be portable across Macs and PowerMacs.
      This goal has implications for the initialization code relating to bus
      locking and slot interrupts.
      During Nubus initialization, bus transactions are "unlocked": on VIA2 and
      RBV machines, via_nubus_init() sets a bit in the via2[gBufB] register to
      allow bus-mastering Nubus cards to arbitrate for the bus. This happens
      upon subsys_initcall(nubus_init). But because nubus_init() has no effect
      on card state, this sequence is arbitrary.
      Moreover, when Penguin is used to boot Linux, the bus is already unlocked
      when Linux starts. On OSS machines there's no attempt to unlock Nubus
      transactions at all. (Maybe there's no benefit on that platform or maybe
      no-one knows how.)
      All of this demonstrates that there's no benefit in locking out
      bus-mastering cards, as yet. (If the need arises, we could lock the bus
      for the duration of a timing-critical operation.) NetBSD unlocks the
      Nubus early (at VIA initialization) and we can do the same.
      via_nubus_init() is also responsible for some VIA interrupt setup that
      should happen earlier than subsys_initcall(nubus_init). And actually, the
      Nubus subsystem need not be involved with slot interrupts: SLOT2IRQ
      works fine because Nubus slot IRQs are geographically assigned
      (regardless of platform).
      For certain platforms with PDS slots, some Nubus IRQs may be platform
      IRQs and this is not something that the NuBus subsystem should worry
      about. So let's invoke via_nubus_init() earlier and make the platform
      responsible for bus unlocking and interrupt setup instead of the NuBus
      Tested-by: default avatarStan Johnson <userm57@yahoo.com>
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
  7. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      How this work was done:
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
      All documentation files were explicitly excluded.
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
         For non */uapi/* files that summary was:
         SPDX license identifier                            # files
         GPL-2.0                                              11139
         and resulted in the first patch in this series.
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                        930
         and resulted in the second patch in this series.
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
         and that resulted in the third patch in this series.
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  8. 14 May, 2017 2 commits
  9. 20 Apr, 2017 3 commits
  10. 24 Dec, 2016 1 commit
  11. 27 Oct, 2014 1 commit
  12. 04 Jun, 2014 1 commit
  13. 04 May, 2013 1 commit
  14. 29 Apr, 2013 1 commit
  15. 09 Apr, 2013 1 commit
  16. 28 Mar, 2012 1 commit
  17. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  18. 16 Oct, 2008 1 commit
  19. 29 Apr, 2008 2 commits
  20. 05 Feb, 2008 1 commit
  21. 03 Feb, 2008 1 commit
  22. 19 Jul, 2007 1 commit
  23. 30 Jun, 2006 1 commit
  24. 16 Apr, 2005 1 commit
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      Let it rip!