1. 05 Jun, 2019 1 commit
  2. 14 May, 2019 1 commit
    • Tony Lindgren's avatar
      mfd: twl6040: Fix device init errors for ACCCTL register · 48171d0e
      Tony Lindgren authored
      I noticed that we can get a -EREMOTEIO errors on at least omap4 duovero:
      
      twl6040 0-004b: Failed to write 2d = 19: -121
      
      And then any following register access will produce errors.
      
      There 2d offset above is register ACCCTL that gets written on twl6040
      powerup. With error checking added to the related regcache_sync() call,
      the -EREMOTEIO error is reproducable on twl6040 powerup at least
      duovero.
      
      To fix the error, we need to wait until twl6040 is accessible after the
      powerup. Based on tests on omap4 duovero, we need to wait over 8ms after
      powerup before register write will complete without failures. Let's also
      make sure we warn about possible errors too.
      
      Note that we have twl6040_patch[] reg_sequence with the ACCCTL register
      configuration and regcache_sync() will write the new value to ACCCTL.
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      48171d0e
  3. 07 Sep, 2018 1 commit
    • David Frey's avatar
      regmap: split up regmap_config.use_single_rw · 1c96a2f6
      David Frey authored
      Split regmap_config.use_single_rw into use_single_read and
      use_single_write. This change enables drivers of devices which only
      support bulk operations in one direction to use the regmap_bulk_*()
      functions for both directions and have their bulk operation split into
      single operations only when necessary.
      
      Update all struct regmap_config instances where use_single_rw==true to
      instead set both use_single_read and use_single_write. No attempt was
      made to evaluate whether it is possible to set only one of
      use_single_read or use_single_write.
      Signed-off-by: default avatarDavid Frey <dpfrey@gmail.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      1c96a2f6
  4. 29 Nov, 2017 1 commit
    • Johan Hovold's avatar
      mfd: twl6040: Fix child-node lookup · 85e9b13c
      Johan Hovold authored
      Fix child-node lookup during probe, which ended up searching the whole
      device tree depth-first starting at the parent rather than just matching
      on its children.
      
      To make things worse, the parent node was prematurely freed, while the
      child node was leaked.
      
      Note that the CONFIG_OF compile guard can be removed as
      of_get_child_by_name() provides a !CONFIG_OF implementation which always
      fails.
      
      Cc: stable <stable@vger.kernel.org>     # 3.5
      Fixes: 37e13cec ("mfd: Add support for Device Tree to twl6040")
      Fixes: ca2cad6a ("mfd: Fix twl6040 build failure")
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      85e9b13c
  5. 04 Oct, 2016 2 commits
  6. 29 Jun, 2016 1 commit
  7. 09 May, 2016 2 commits
  8. 26 Oct, 2015 1 commit
    • Tony Lindgren's avatar
      mfd: twl6040: Fix deferred probe handling for clk32k · 75c08f17
      Tony Lindgren authored
      Commit 68bab866 ("mfd: twl6040: Optional clk32k clock handling")
      added clock handling for the 32k clock from palmas-clk. However, that
      patch did not consider a typical situation where twl6040 is built-in,
      and palmas-clk is a loadable module like we have in omap2plus_defconfig.
      
      If palmas-clk is not loaded before twl6040 probes, we will get a
      "clk32k is not handled" warning during booting. This means that any
      drivers relying on this clock will mysteriously fail, including
      omap5-uevm WLAN and audio.
      
      Note that for WLAN, we probably should also eventually get
      the clk32kgaudio for MMC3 directly as that's shared between
      audio and WLAN SDIO at least for omap5-uevm. It seems the
      WLAN chip cannot get it as otherwise MMC3 won't get properly
      probed.
      
      Fixes: 68bab866 ("mfd: twl6040: Optional clk32k clock handling")
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      Reviewed-by: default avatarFelipe Balbi <balbi@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      75c08f17
  9. 11 Aug, 2015 1 commit
  10. 16 Jul, 2015 1 commit
  11. 30 Mar, 2015 1 commit
  12. 22 Jan, 2015 1 commit
  13. 26 Sep, 2014 1 commit
  14. 22 Jul, 2014 1 commit
    • Lee Jones's avatar
      mfd: twl6040: Fix 'insert space after ','', error · c06f308a
      Lee Jones authored
      This is part of an effort to clean-up the MFD subsystem.
      
      ERROR: space required after that ',' (ctx:VxO)
      +                                 0, &twl6040_irq_chip,&twl6040->irq_data);
                                                            ^
      
      ERROR: space required before that '&' (ctx:OxV)
      +                                 0, &twl6040_irq_chip,&twl6040->irq_data);
                                                             ^
      
      total: 2 errors, 0 warnings, 816 lines checked
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      c06f308a
  15. 03 Jun, 2014 5 commits
  16. 19 Mar, 2014 2 commits
  17. 21 Jan, 2014 1 commit
  18. 19 Dec, 2013 1 commit
  19. 24 Oct, 2013 1 commit
  20. 23 Oct, 2013 1 commit
  21. 02 Sep, 2013 1 commit
  22. 31 Jul, 2013 3 commits
  23. 08 Apr, 2013 1 commit
  24. 03 Jan, 2013 1 commit
    • Greg Kroah-Hartman's avatar
      Drivers: mfd: remove __dev* attributes. · 612b95cd
      Greg Kroah-Hartman authored
      CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
      markings need to be removed.
      
      This change removes the use of __devinit, __devexit_p, __devinitdata,
      __devinitconst, and __devexit from these drivers.
      
      Based on patches originally written by Bill Pemberton, but redone by me
      in order to handle some of the coding style issues better, by hand.
      
      Cc: Bill Pemberton <wfp5p@virginia.edu>
      Cc: Samuel Ortiz <sameo@linux.intel.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      612b95cd
  25. 21 Nov, 2012 1 commit
  26. 13 Nov, 2012 6 commits