• Andreas Kemnade's avatar
    regulator: twl: voltage lists for vdd1/2 on twl4030 · 3829100a
    Andreas Kemnade authored
    _opp_supported_by_regulators() wrongly ignored errors from
    regulator_is_supported_voltage(), so it considered errors as
    success. Since
    commit 49820944 ("regulator: core: simplify return value on suported_voltage")
    regulator_is_supported_voltage() returns a real boolean, so
    errors make _opp_supported_by_regulators() return false.
    
    That reveals a problem with the declaration of the VDD1/2
    regulators on twl4030.
    The VDD1/VDD2 regulators on twl4030 are neither defined with
    voltage lists nor with the continuous flag set, so
    regulator_is_supported_voltage() returns false and an error
    before above mentioned commit (which was considered success)
    The result is that after the above mentioned commit cpufreq
    does not work properly e.g. dm3730.
    
    [    2.490997] core: _opp_supported_by_regulators: OPP minuV: 1012500 maxuV: 1012500, not supported by regulator
    [    2.501617] cpu cpu0: _opp_add: OPP not supported by regulators (300000000)
    [    2.509246] core: _opp_supported_by_regulators: OPP minuV: 1200000 maxuV: 1200000, not supported by regulator
    [    2.519775] cpu cpu0: _opp_add: OPP not supported by regulators (600000000)
    [    2.527313] core: _opp_supported_by_regulators: OPP minuV: 1325000 maxuV: 1325000, not supported by regulator
    [    2.537750] cpu cpu0: _opp_add: OPP not supported by regulators (800000000)
    
    The patch fixes declaration of VDD1/2 regulators by
    adding proper voltage lists.
    
    Fixes: 49820944 ("regulator: core: simplify return value on suported_voltage")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarAndreas Kemnade <andreas@kemnade.info>
    Tested-by: Adam Ford <aford173@gmail.com> #logicpd-torpedo-37xx-devkit
    Link: https://lore.kernel.org/r/20190814214319.24087-1-andreas@kemnade.infoSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    3829100a
Name
Last commit
Last update
..
88pg86x.c Loading commit data...
88pm800-regulator.c Loading commit data...
88pm8607.c Loading commit data...
Kconfig Loading commit data...
Makefile Loading commit data...
aat2870-regulator.c Loading commit data...
ab3100.c Loading commit data...
ab8500-ext.c Loading commit data...
ab8500.c Loading commit data...
act8865-regulator.c Loading commit data...
act8945a-regulator.c Loading commit data...
ad5398.c Loading commit data...
anatop-regulator.c Loading commit data...
arizona-ldo1.c Loading commit data...
arizona-micsupp.c Loading commit data...
as3711-regulator.c Loading commit data...
as3722-regulator.c Loading commit data...
axp20x-regulator.c Loading commit data...
bcm590xx-regulator.c Loading commit data...
bd70528-regulator.c Loading commit data...
bd718x7-regulator.c Loading commit data...
bd9571mwv-regulator.c Loading commit data...
core.c Loading commit data...
cpcap-regulator.c Loading commit data...
da903x.c Loading commit data...
da9052-regulator.c Loading commit data...
da9055-regulator.c Loading commit data...
da9062-regulator.c Loading commit data...
da9063-regulator.c Loading commit data...
da9210-regulator.c Loading commit data...
da9210-regulator.h Loading commit data...
da9211-regulator.c Loading commit data...
da9211-regulator.h Loading commit data...
db8500-prcmu.c Loading commit data...
dbx500-prcmu.c Loading commit data...
dbx500-prcmu.h Loading commit data...
devres.c Loading commit data...
dummy.c Loading commit data...
dummy.h Loading commit data...
fan53555.c Loading commit data...
fixed-helper.c Loading commit data...
fixed.c Loading commit data...
gpio-regulator.c Loading commit data...
helpers.c Loading commit data...
hi6421-regulator.c Loading commit data...
hi6421v530-regulator.c Loading commit data...
hi655x-regulator.c Loading commit data...
internal.h Loading commit data...
isl6271a-regulator.c Loading commit data...
isl9305.c Loading commit data...
lm363x-regulator.c Loading commit data...
lochnagar-regulator.c Loading commit data...
lp3971.c Loading commit data...
lp3972.c Loading commit data...
lp872x.c Loading commit data...
lp873x-regulator.c Loading commit data...
lp8755.c Loading commit data...
lp87565-regulator.c Loading commit data...
lp8788-buck.c Loading commit data...
lp8788-ldo.c Loading commit data...
ltc3589.c Loading commit data...
ltc3676.c Loading commit data...
max14577-regulator.c Loading commit data...
max1586.c Loading commit data...
max77620-regulator.c Loading commit data...
max77650-regulator.c Loading commit data...
max77686-regulator.c Loading commit data...
max77693-regulator.c Loading commit data...
max77802-regulator.c Loading commit data...
max8649.c Loading commit data...
max8660.c Loading commit data...
max8907-regulator.c Loading commit data...
max8925-regulator.c Loading commit data...
max8952.c Loading commit data...
max8973-regulator.c Loading commit data...
max8997-regulator.c Loading commit data...
max8998.c Loading commit data...
mc13783-regulator.c Loading commit data...
mc13892-regulator.c Loading commit data...
mc13xxx-regulator-core.c Loading commit data...
mc13xxx.h Loading commit data...
mcp16502.c Loading commit data...
mt6311-regulator.c Loading commit data...
mt6311-regulator.h Loading commit data...
mt6323-regulator.c Loading commit data...
mt6380-regulator.c Loading commit data...
mt6397-regulator.c Loading commit data...
of_regulator.c Loading commit data...
palmas-regulator.c Loading commit data...
pbias-regulator.c Loading commit data...
pcap-regulator.c Loading commit data...
pcf50633-regulator.c Loading commit data...
pfuze100-regulator.c Loading commit data...
pv88060-regulator.c Loading commit data...
pv88060-regulator.h Loading commit data...
pv88080-regulator.c Loading commit data...
pv88080-regulator.h Loading commit data...
pv88090-regulator.c Loading commit data...
pv88090-regulator.h Loading commit data...
pwm-regulator.c Loading commit data...
qcom-rpmh-regulator.c Loading commit data...
qcom_rpm-regulator.c Loading commit data...
qcom_smd-regulator.c Loading commit data...
qcom_spmi-regulator.c Loading commit data...
rc5t583-regulator.c Loading commit data...
rk808-regulator.c Loading commit data...
rn5t618-regulator.c Loading commit data...
rt5033-regulator.c Loading commit data...
s2mpa01.c Loading commit data...
s2mps11.c Loading commit data...
s5m8767.c Loading commit data...
sc2731-regulator.c Loading commit data...
sky81452-regulator.c Loading commit data...
slg51000-regulator.c Loading commit data...
slg51000-regulator.h Loading commit data...
stm32-booster.c Loading commit data...
stm32-pwr.c Loading commit data...
stm32-vrefbuf.c Loading commit data...
stpmic1_regulator.c Loading commit data...
stw481x-vmmc.c Loading commit data...
sy8106a-regulator.c Loading commit data...
ti-abb-regulator.c Loading commit data...
tps51632-regulator.c Loading commit data...
tps6105x-regulator.c Loading commit data...
tps62360-regulator.c Loading commit data...
tps65023-regulator.c Loading commit data...
tps6507x-regulator.c Loading commit data...
tps65086-regulator.c Loading commit data...
tps65090-regulator.c Loading commit data...
tps65132-regulator.c Loading commit data...
tps65217-regulator.c Loading commit data...
tps65218-regulator.c Loading commit data...
tps6524x-regulator.c Loading commit data...
tps6586x-regulator.c Loading commit data...
tps65910-regulator.c Loading commit data...
tps65912-regulator.c Loading commit data...
tps80031-regulator.c Loading commit data...
twl-regulator.c Loading commit data...
twl6030-regulator.c Loading commit data...
uniphier-regulator.c Loading commit data...
userspace-consumer.c Loading commit data...
vctrl-regulator.c Loading commit data...
vexpress-regulator.c Loading commit data...
virtual.c Loading commit data...
wm831x-dcdc.c Loading commit data...
wm831x-isink.c Loading commit data...
wm831x-ldo.c Loading commit data...
wm8350-regulator.c Loading commit data...
wm8400-regulator.c Loading commit data...
wm8994-regulator.c Loading commit data...