• Eric Biggers's avatar
    KEYS: fix parsing invalid pkey info string · 57b0e314
    Eric Biggers authored
    We need to check the return value of match_token() for Opt_err before
    doing anything with it.
    
    [ Not only did the old "-1" value for Opt_err cause problems for the
      __test_and_set_bit(), as fixed in commit 94c13f66 ("security:
      don't use a negative Opt_err token index"), but accessing
      "args[0].from" is invalid for the Opt_err case, as pointed out by Eric
      later.  - Linus ]
    
    Reported-by: syzbot+a22e0dc07567662c50bc@syzkaller.appspotmail.com
    Fixes: 00d60fd3 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")
    Signed-off-by: 's avatarEric Biggers <ebiggers@google.com>
    Cc: stable@kernel.org # 4.20
    Signed-off-by: 's avatarLinus Torvalds <torvalds@linux-foundation.org>
    57b0e314
Name
Last commit
Last update
..
encrypted-keys Loading commit data...
Kconfig Loading commit data...
Makefile Loading commit data...
big_key.c Loading commit data...
compat.c Loading commit data...
compat_dh.c Loading commit data...
dh.c Loading commit data...
gc.c Loading commit data...
internal.h Loading commit data...
key.c Loading commit data...
keyctl.c Loading commit data...
keyctl_pkey.c Loading commit data...
keyring.c Loading commit data...
permission.c Loading commit data...
persistent.c Loading commit data...
proc.c Loading commit data...
process_keys.c Loading commit data...
request_key.c Loading commit data...
request_key_auth.c Loading commit data...
sysctl.c Loading commit data...
trusted.c Loading commit data...
user_defined.c Loading commit data...