• Linus Torvalds's avatar
    Fix 'acccess_ok()' on alpha and SH · 94bd8a05
    Linus Torvalds authored
    Commit 594cc251 ("make 'user_access_begin()' do 'access_ok()'")
    broke both alpha and SH booting in qemu, as noticed by Guenter Roeck.
    It turns out that the bug wasn't actually in that commit itself (which
    would have been surprising: it was mostly a no-op), but in how the
    addition of access_ok() to the strncpy_from_user() and strnlen_user()
    functions now triggered the case where those functions would test the
    access of the very last byte of the user address space.
    The string functions actually did that user range test before too, but
    they did it manually by just comparing against user_addr_max().  But
    with user_access_begin() doing the check (using "access_ok()"), it now
    exposed problems in the architecture implementations of that function.
    For example, on alpha, the access_ok() helper macro looked like this:
      #define __access_ok(addr, size) \
            ((get_fs().seg & (addr | size | (addr+size))) == 0)
    and what it basically tests is of any of the high bits get set (the
    USER_DS masking value is 0xfffffc0000000000).
    And that's completely wrong for the "addr+size" check.  Because it's
    off-by-one for the case where we check to the very end of the user
    address space, which is exactly what the strn*_user() functions do.
    Why? Because "addr+size" will be exactly the size of the address space,
    so trying to access the last byte of the user address space will fail
    the __access_ok() check, even though it shouldn't.  As a result, the
    user string accessor functions failed consistently - because they
    literally don't know how long the string is going to be, and the max
    access is going to be that last byte of the user address space.
    Side note: that alpha macro is buggy for another reason too - it re-uses
    the arguments twice.
    And SH has another version of almost the exact same bug:
      #define __addr_ok(addr) \
            ((unsigned long __force)(addr) < current_thread_info()->addr_limit.seg)
    so far so good: yes, a user address must be below the limit.  But then:
      #define __access_ok(addr, size)         \
            (__addr_ok((addr) + (size)))
    is wrong with the exact same off-by-one case: the case when "addr+size"
    is exactly _equal_ to the limit is actually perfectly fine (think "one
    byte access at the last address of the user address space")
    The SH version is actually seriously buggy in another way: it doesn't
    actually check for overflow, even though it did copy the _comment_ that
    talks about overflow.
    So it turns out that both SH and alpha actually have completely buggy
    implementations of access_ok(), but they happened to work in practice
    (although the SH overflow one is a serious serious security bug, not
    that anybody likely cares about SH security).
    This fixes the problems by using a similar macro on both alpha and SH.
    It isn't trying to be clever, the end address is based on this logic:
            unsigned long __ao_end = __ao_a + __ao_b - !!__ao_b;
    which basically says "add start and length, and then subtract one unless
    the length was zero".  We can't subtract one for a zero length, or we'd
    just hit an underflow instead.
    For a lot of access_ok() users the length is a constant, so this isn't
    actually as expensive as it initially looks.
    Reported-and-tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Cc: Matt Turner <mattst88@gmail.com>
    Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Last commit
Last update
alpha Loading commit data...
arc Loading commit data...
arm Loading commit data...
arm64 Loading commit data...
c6x Loading commit data...
csky Loading commit data...
h8300 Loading commit data...
hexagon Loading commit data...
ia64 Loading commit data...
m68k Loading commit data...
microblaze Loading commit data...
mips Loading commit data...
nds32 Loading commit data...
nios2 Loading commit data...
openrisc Loading commit data...
parisc Loading commit data...
powerpc Loading commit data...
riscv Loading commit data...
s390 Loading commit data...
sh Loading commit data...
sparc Loading commit data...
um Loading commit data...
unicore32 Loading commit data...
x86 Loading commit data...
xtensa Loading commit data...
.gitignore Loading commit data...
Kconfig Loading commit data...