• Nadav Amit's avatar
    vmw_balloon: Fix offline page marking with compaction · 468e0ffa
    Nadav Amit authored
    The compaction code already marks pages as offline when it enqueues
    pages in the ballooned page list, and removes the mapping when the pages
    are removed from the list. VMware balloon also updates the flags,
    instead of letting the balloon-compaction logic handle it, which causes
    the assertion VM_BUG_ON_PAGE(!PageOffline(page)) to fire, when
    __ClearPageOffline is called the second time. This causes the following
    crash.
    
    [  487.104520] kernel BUG at include/linux/page-flags.h:749!
    [  487.106364] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC PTI
    [  487.107681] CPU: 7 PID: 1106 Comm: kworker/7:3 Not tainted 5.3.0-rc5balloon #227
    [  487.109196] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 12/12/2018
    [  487.111452] Workqueue: events_freezable vmballoon_work [vmw_balloon]
    [  487.112779] RIP: 0010:vmballoon_release_page_list+0xaa/0x100 [vmw_balloon]
    [  487.114200] Code: fe 48 c1 e7 06 4c 01 c7 8b 47 30 41 89 c1 41 81 e1 00 01 00 f0 41 81 f9 00 00 00 f0 74 d3 48 c7 c6 08 a1 a1 c0 e8 06 0d e7 ea <0f> 0b 44 89 f6 4c 89 c7 e8 49 9c e9 ea 49 8d 75 08 49 8b 45 08 4d
    [  487.118033] RSP: 0018:ffffb82f012bbc98 EFLAGS: 00010246
    [  487.119135] RAX: 0000000000000037 RBX: 0000000000000001 RCX: 0000000000000006
    [  487.120601] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff9a85b6bd7620
    [  487.122071] RBP: ffffb82f012bbcc0 R08: 0000000000000001 R09: 0000000000000000
    [  487.123536] R10: 0000000000000000 R11: 0000000000000000 R12: ffffb82f012bbd00
    [  487.125002] R13: ffffe97f4598d9c0 R14: 0000000000000000 R15: ffffb82f012bbd34
    [  487.126463] FS:  0000000000000000(0000) GS:ffff9a85b6bc0000(0000) knlGS:0000000000000000
    [  487.128110] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    [  487.129316] CR2: 00007ffe6e413ea0 CR3: 0000000230b18001 CR4: 00000000003606e0
    [  487.130812] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    [  487.132283] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
    [  487.133749] Call Trace:
    [  487.134333]  vmballoon_deflate+0x22c/0x390 [vmw_balloon]
    [  487.135468]  vmballoon_work+0x6e7/0x913 [vmw_balloon]
    [  487.136711]  ? process_one_work+0x21a/0x5e0
    [  487.138581]  process_one_work+0x298/0x5e0
    [  487.139926]  ? vmballoon_migratepage+0x310/0x310 [vmw_balloon]
    [  487.141610]  ? process_one_work+0x298/0x5e0
    [  487.143053]  worker_thread+0x41/0x400
    [  487.144389]  kthread+0x12b/0x150
    [  487.145582]  ? process_one_work+0x5e0/0x5e0
    [  487.146937]  ? kthread_create_on_node+0x60/0x60
    [  487.148637]  ret_from_fork+0x3a/0x50
    
    Fix it by updating the PageOffline indication only when a 2MB page is
    enqueued and dequeued. The 4KB pages will be handled correctly by the
    balloon compaction logic.
    
    Fixes: 83a8afa7 ("vmw_balloon: Compaction support")
    Cc: David Hildenbrand <david@redhat.com>
    Reported-by: 's avatarThomas Hellstrom <thellstrom@vmware.com>
    Signed-off-by: 's avatarNadav Amit <namit@vmware.com>
    Link: https://lore.kernel.org/r/20190820160121.452-1-namit@vmware.comSigned-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    468e0ffa
Name
Last commit
Last update
..
altera-stapl Loading commit data...
c2port Loading commit data...
cardreader Loading commit data...
cb710 Loading commit data...
cxl Loading commit data...
echo Loading commit data...
eeprom Loading commit data...
genwqe Loading commit data...
habanalabs Loading commit data...
ibmasm Loading commit data...
lis3lv02d Loading commit data...
lkdtm Loading commit data...
mei Loading commit data...
mic Loading commit data...
ocxl Loading commit data...
sgi-gru Loading commit data...
sgi-xp Loading commit data...
ti-st Loading commit data...
vmw_vmci Loading commit data...
Kconfig Loading commit data...
Makefile Loading commit data...
ad525x_dpot-i2c.c Loading commit data...
ad525x_dpot-spi.c Loading commit data...
ad525x_dpot.c Loading commit data...
ad525x_dpot.h Loading commit data...
apds9802als.c Loading commit data...
apds990x.c Loading commit data...
atmel-ssc.c Loading commit data...
atmel_tclib.c Loading commit data...
bh1770glc.c Loading commit data...
cs5535-mfgpt.c Loading commit data...
ds1682.c Loading commit data...
dummy-irq.c Loading commit data...
enclosure.c Loading commit data...
fastrpc.c Loading commit data...
hmc6352.c Loading commit data...
hpilo.c Loading commit data...
hpilo.h Loading commit data...
ibmvmc.c Loading commit data...
ibmvmc.h Loading commit data...
ics932s401.c Loading commit data...
ioc4.c Loading commit data...
isl29003.c Loading commit data...
isl29020.c Loading commit data...
kgdbts.c Loading commit data...
lattice-ecp3-config.c Loading commit data...
pch_phub.c Loading commit data...
pci_endpoint_test.c Loading commit data...
phantom.c Loading commit data...
pti.c Loading commit data...
pvpanic.c Loading commit data...
qcom-coincell.c Loading commit data...
spear13xx_pcie_gadget.c Loading commit data...
sram-exec.c Loading commit data...
sram.c Loading commit data...
sram.h Loading commit data...
tifm_7xx1.c Loading commit data...
tifm_core.c Loading commit data...
tsl2550.c Loading commit data...
vexpress-syscfg.c Loading commit data...
vmw_balloon.c Loading commit data...
xilinx_sdfec.c Loading commit data...