Commit e2efacb6 authored by Yazen Ghannam's avatar Yazen Ghannam Committed by Thomas Gleixner
Browse files

Revert "x86/mce/AMD: Collect error info even if valid bits are not set"

This reverts commit 4b1e8427

.

Software uses the valid bits to decide if the values can be used for
further processing or other actions. So setting the valid bits will have
software act on values that it shouldn't be acting on.

The recommendation to save all the register values does not mean that
the values are always valid.
Signed-off-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: tony.luck@intel.com
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: bp@suse.de
Cc: linux-edac@vger.kernel.org
Link: https://lkml.kernel.org/r/20180326191526.64314-1-Yazen.Ghannam@amd.com
parent 24193c5d
......@@ -446,20 +446,6 @@ static inline void mce_gather_info(struct mce *m, struct pt_regs *regs)
if (mca_cfg.rip_msr)
m->ip = mce_rdmsrl(mca_cfg.rip_msr);
}
/*
* Error handlers should save the values in MCA_ADDR, MCA_MISC0, and
* MCA_SYND even if MCA_STATUS[AddrV], MCA_STATUS[MiscV], and
* MCA_STATUS[SyndV] are zero.
*/
if (m->cpuvendor == X86_VENDOR_AMD) {
u64 status = MCI_STATUS_ADDRV | MCI_STATUS_MISCV;
if (mce_flags.smca)
status |= MCI_STATUS_SYNDV;
m->status |= status;
}
}
int mce_available(struct cpuinfo_x86 *c)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment