1. 07 Jan, 2019 2 commits
  2. 12 Oct, 2018 3 commits
  3. 10 Oct, 2018 19 commits
  4. 01 Oct, 2018 11 commits
  5. 12 Sep, 2018 3 commits
    • Vadym Shovkoplias's avatar
      glsl/linker: Check the invariance of built-in special variables · 9b5c0c52
      Vadym Shovkoplias authored
      From Section 4.6.4 (Invariance and Linkage) of the GLSL ES 1.0 specification
      
          "The invariance of varyings that are declared in both the vertex and
           fragment shaders must match. For the built-in special variables,
           gl_FragCoord can only be declared invariant if and only if
           gl_Position is declared invariant. Similarly gl_PointCoord can only
           be declared invariant if and only if gl_PointSize is declared
           invariant. It is an error to declare gl_FrontFacing as invariant.
           The invariance of gl_FrontFacing is the same as the invariance of
           gl_Position."
      
      Fixes:
          * glsl-pcoord-invariant.shader_test
          * glsl-fcoord-invariant.shader_test
          * glsl-fface-invariant.shader_test
      
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107734
      
      Signed-off-by: default avatarVadym Shovkoplias <vadym.shovkoplias@globallogic.com>
      Reviewed-by: default avatarTapani Pälli <tapani.palli@intel.com>
      9b5c0c52
    • Tapani Pälli's avatar
      intel/tools: fix initial position of window in aubinator viewer · 30580640
      Tapani Pälli authored
      
      
      Currently position is set before widgets are sized by gtk and
      calculation can get wrong results where window is positioned
      offscreen. Patch fixes this by setting aubfile window position
      as 0,0 only when size_allocate has been called to the widget.
      
      Now window is always positioned to 0,0 if imgui.ini is missing.
      Signed-off-by: default avatarTapani Pälli <tapani.palli@intel.com>
      Reviewed-by: default avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      30580640
    • Erik Faye-Lund's avatar
      winsys/virgl: avoid unintended behavior · eaa71858
      Erik Faye-Lund authored
      If we end up never taking the loop that writes ret, we can end up with
      an uninitialized value, and if we're *really* unlucky, that value can
      be -1, causing us to go down an error-path instead of a success path.
      
      This was obviously not intended, so let's just initialize this to zero.
      
      Noticed by Valgrind:
      
      Conditional jump or move depends on uninitialised value(s)
         at 0xBA640A0: virgl_drm_winsys_resource_cache_create (virgl_drm_winsys.c:348)
         by 0xBA62FCF: virgl_buffer_create (virgl_buffer.c:170)
         by 0xBA605AC: virgl_resource_create (virgl_resource.c:60)
         by 0xBCF816F: bufferobj_data (st_cb_bufferobjects.c:344)
         by 0xBCF816F: st_bufferobj_data (st_cb_bufferobjects.c:390)
         by 0xBB7E836: vbo_use_buffer_objects (vbo_exec_api.c:1136)
         by 0xBCFCC6E: st_create_context_priv (st_context.c:414)
         by 0xBCFD3CD: st_create_context (st_context.c:590)
         by 0xBBB30CA: st_api_create_context (st_manager.c:896)
         by 0xB981E76: dri_create_context (dri_context.c:155)
         by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473)
         by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309)
         by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78)
      
      Fixes: a8987b88
      
       ("virgl: add driver for virtio-gpu 3D (v2)")
      Signed-off-by: default avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      eaa71858
  6. 11 Sep, 2018 2 commits