Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • M millipixels
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Librem5
  • millipixels
  • Issues
  • #23
Closed
Open
Created Sep 20, 2021 by Martin Kepplinger@martin.kepplingerOwner

don't set digital gain if analogue gain is being used

the logic seems to be: if CID_GAIN is available, use that, else if CID_ANALOGUE_GAIN available, that.

the selfie cam provides CID_ANALOGUE_GAIN but somewhere the drivers's set_ctrl for CID_DIGITAL_GAIN is being called. where? Since that's an "image processing" control, this looks like a bug. What is meant to be used is the "source control" (analogue gain).

since the selfie cam driver can apply per-channel (digital) gain for white balance calibration, this is especially bad, as white-balance gain values will be overwritten if CID_DIGITAL_GAIN is used by the user (megapixels).

Assignee
Assign to
Time tracking