Duplicated symbol on Arch Linux with GCC 10
Hi,
Building Phoc (HEAD/1df1653898fd89183900516f5080aa0d5ccedcf8
) fails on Arch Linux due to multiple definitions of the same symbol. This caused by variable declarations in subprojects/include/types/wlr_seat.h
. Namely
// subprojects/include/types/wlr_seat.h
const struct wlr_pointer_grab_interface default_pointer_grab_impl;
const struct wlr_keyboard_grab_interface default_keyboard_grab_impl;
const struct wlr_touch_grab_interface default_touch_grab_impl;
Which can be fixed by prepending extern
.
index 0ccb3345..2a3cd69b 100644
--- a/include/types/wlr_seat.h
+++ b/include/types/wlr_seat.h
@@ -4,9 +4,9 @@
#include <wayland-server-core.h>
#include <wlr/types/wlr_seat.h>
-const struct wlr_pointer_grab_interface default_pointer_grab_impl;
-const struct wlr_keyboard_grab_interface default_keyboard_grab_impl;
-const struct wlr_touch_grab_interface default_touch_grab_impl;
+extern const struct wlr_pointer_grab_interface default_pointer_grab_impl;
+extern const struct wlr_keyboard_grab_interface default_keyboard_grab_impl;
+extern const struct wlr_touch_grab_interface default_touch_grab_impl;
void seat_client_create_pointer(struct wlr_seat_client *seat_client,
uint32_t version, uint32_t id);
This problem have been fixed by upstream wlroots f2943bd. Should phoc pull from upstream or should I make a quick MR?
Thanks