The source project of this merge request has been removed.
Add -Wshadow to cflags
All threads resolved!
All threads resolved!
This is one part of issue #5.
Merge request reports
Activity
Filter activity
mentioned in merge request !129 (closed)
@anteater looks good to me code wise (and it seems wlroots copes as well now - which was one of the reason this wasn't turned on earlier). Thanks for hanving a look!
Could you split into 3 commits so e.g. reverts and bisects stay simple:
- one fixing up keybindings.h (since this is a real bug declaring a
seat
variable which is never used) - one fixing up the cursor.c (this is an actual -Wshadow case)
- the last one turning on -Wshadow (this flips the switch to not regress)
i'm then happy to merge this.
Edited by Guido Gunther- one fixing up keybindings.h (since this is a real bug declaring a
- Resolved by Guido Gunther
@anteater ping? Otherwise i can make that split if you're busy otherwise.
mentioned in merge request !134 (merged)
Please register or sign in to reply