Window thumbnails

mentioned in merge request phosh!481 (merged)

as a general note: i'd like to retire the phosh private protocol so it might make sense to use a phosh2 protocol and start versioning with 1 there (or better propose something upstream).

I will propose things upstream, but it will take some time since this also asks for a xdg-foreign-toplevel-management rework so it's likely that we'll end up temporarily using the private protocol anyway.

However, yeah, phosh2 makes a lot of sense

added 10 commits

• bb4cc74e...ff0c3ea9 - 2 commits from branch Librem5:master
• 68f2f0e7 - protocols: Add wlr-screencopy-unstable-v1
• 6bc11eaa - protocols: Add wlr-foreign-toplevel-management-unstable-v1
• 4b35e100 - Create render.h header to hold declarations from render.c
• a110f658 - view: Make view_get_geometry accessible outside of view.c
• 85f6a267 - view: Store a pointer to view in wlr_foreign_toplevel_handle data
• 24dd5c74 - meson: Depend on GLESv2
• b7e5ebd5 - WIP: Implement window thumbnails via...
• 8dab3cb8 - phosh: Drop unused xdg-switcher part of the private protocol

Compare with previous version

phoc side is now IMO pretty close to done. It doesn't require custom wlroots patch anymore. Still needs copy_with_damage support, timestamp in send_ready and conflicts relation against older phosh versions.

changed the description

mentioned in issue #88

added 4 commits

• 36cfb791 - view: Store a pointer to view in wlr_foreign_toplevel_handle data
• 0c8614ff - meson: Depend on GLESv2
• 846095fe - WIP: Implement window thumbnails via...
• ed4a6e09 - phosh: Drop unused xdg-switcher part of the private protocol

Compare with previous version

mentioned in merge request !147 (merged)

added 53 commits

• ed4a6e09...232fa822 - 46 commits from branch Librem5:master
• 67522b8c - protocols: Add wlr-foreign-toplevel-management-unstable-v1
• 0079f8f4 - Create render.h header to hold declarations from render.c
• 311db040 - view: Make view_get_geometry accessible outside of view.c
• d0174301 - view: Store a pointer to view in wlr_foreign_toplevel_handle data
• b9852862 - meson: Depend on GLESv2
• c4db90a6 - Implement window thumbnails via...
• 74dbf1a1 - phosh: Drop unused xdg-switcher part of the private protocol

Compare with previous version

added 3 commits

• 3ddb20ad - protocols: Update wlr-screencopy-unstable-v1 to version 2
• ebbd533f - Implement window thumbnails via...
• c9e42223 - phosh: Drop unused xdg-switcher part of the private protocol

Compare with previous version

unmarked as a Work In Progress

added 10 commits

• c9e42223...74df8ce6 - 2 commits from branch Librem5:master
• dcd176b8 - protocols: Add wlr-foreign-toplevel-management-unstable-v1
• 41beb84f - Create render.h header to hold declarations from render.c
• 12c7befb - view: Make view_get_geometry accessible outside of view.c
• 0c62d3db - view: Store a pointer to view in wlr_foreign_toplevel_handle data
• 003744fc - meson: Depend on GLESv2
• 505cd804 - protocols: Update wlr-screencopy-unstable-v1 to version 2
• 82885888 - Implement window thumbnails via...
• e73fd476 - phosh: Drop unused xdg-switcher part of the private protocol

Compare with previous version

What about adding a test for the new protocol?

i wonder if it would ease testing (and merging) if you'd put the part that drops the old protocol into a separate MR . We can then merge in thumbnails and merge the protocol drop right before the release (together with the phosh side of that) which would dientangle things a bit. Since it's at the end of the series it should be easy todo.

Most of the discussion is happening over in phosh!481 (merged) but from my PoV we could already merge the first bunch of patches (except for the actual implementation and the private protocol drop) to make this smaller if it helps.

added 21 commits

• e73fd476...1141e4a4 - 14 commits from branch Librem5:master
• 3affe00b - protocols: Add wlr-foreign-toplevel-management-unstable-v1
• 06c69ece - Create render.h header to hold declarations from render.c
• 9f62d7fc - view: Make view_get_geometry accessible outside of view.c
• 48f3ff1c - view: Store a pointer to view in wlr_foreign_toplevel_handle data
• 2818b063 - meson: Depend on GLESv2
• 4097a2ba - protocols: Update wlr-screencopy-unstable-v1 to version 2
• 1914fb02 - Implement window thumbnails via...

Compare with previous version

mentioned in merge request !160 (merged)

marked as a Work In Progress

changed the description

Split into !160 (merged). Still working on tests.

added 8 commits

• 1914fb02...1df16538 - 7 commits from branch Librem5:master
• 45b25fe1 - Implement window thumbnails via...

Compare with previous version

added 6 commits

• 1bcac54d - 1 commit from branch Librem5:master
• 80a57a47 - Implement window thumbnails via...
• 33ce7056 - tests: Introduce PhocTestScreencopyFrame and generalize screencopy logic
• 9a9d71ff - tests: Fix inverted condition in phoc_test_buffer_equal
• c2eef296 - tests: phoc_test_client_capture_output: Handle ARGB/XRGB format mismatch
• aa6e8bdb - tests: Basic window thumbnail test

Compare with previous version

unmarked as a Work In Progress

changed the description

added 1 commit

• 4030173b - tests: Basic window thumbnail test

Compare with previous version

I want to write more tests here later (subsurfaces, different surface scales etc. - should be pretty easy with all building blocks now in place), but lets get it and phosh!481 (merged) into shape first.

besides the formatting nits this looks good to go to me.

added 6 commits

• 4782a496 - Implement window thumbnails via...
• 78c63f1c - tests: Introduce PhocTestScreencopyFrame and generalize screencopy logic
• 2798f3de - tests: Fix inverted condition in phoc_test_buffer_equal
• 6b3693f2 - tests: phoc_test_client_capture_output: Handle ARGB/XRGB format mismatch
• 5ca67a4b - tests: Basic window thumbnail test
• 7316b23b - protocols: Add a description for thumbnail interface in phosh-private

Compare with previous version

Updated

added 6 commits

• 98f29a6d - Implement window thumbnails via...
• 444a8325 - tests: Introduce PhocTestScreencopyFrame and generalize screencopy logic
• b1e75596 - tests: Fix inverted condition in phoc_test_buffer_equal
• 2f516f61 - tests: phoc_test_client_capture_output: Handle ARGB/XRGB format mismatch
• c6f443c7 - tests: Basic window thumbnail test
• a00c7b16 - protocols: Add a description for thumbnail interface in phosh-private

Compare with previous version

resolved all threads

merged