phosh issueshttps://source.puri.sm/Librem5/phosh/-/issues2020-01-10T15:24:07Zhttps://source.puri.sm/Librem5/phosh/-/issues/16Support PINs of arbirtrary length2020-01-10T15:24:07ZGuido GuntherSupport PINs of arbirtrary lengthFeature: https://source.puri.sm/Librem5/use-cases/issues/46, https://source.puri.sm/Librem5/use-cases/issues/45
We don't want to force the user to use 6 digits only.Feature: https://source.puri.sm/Librem5/use-cases/issues/46, https://source.puri.sm/Librem5/use-cases/issues/45
We don't want to force the user to use 6 digits only.https://source.puri.sm/Librem5/phosh/-/issues/31Lockscreen: cannot enter *+ button more than once2019-12-13T18:36:35ZHeather EllsworthLockscreen: cannot enter *+ button more than onceFeature: https://source.puri.sm/Librem5/use-cases/issues/45
Super minor issue, but on the lockscreen it's strange that you can enter all of the other keys as much as you want (and see the corresponding dot show up) EXCEPT the *+ button....Feature: https://source.puri.sm/Librem5/use-cases/issues/45
Super minor issue, but on the lockscreen it's strange that you can enter all of the other keys as much as you want (and see the corresponding dot show up) EXCEPT the *+ button. No matter how many times you click the *+ button, only one dot appears, indicating that it has been registered only once.https://source.puri.sm/Librem5/phosh/-/issues/69Unlock screen doesn't match design2019-12-13T18:35:53ZHeather EllsworthUnlock screen doesn't match designFeature: https://source.puri.sm/Librem5/use-cases/issues/45
The backspace button shown in the [unlock screen mockup](https://gitlab.gnome.org/Teams/Design/os-mockups/blob/master/mobile-shell/mobile-shell-screens.png) appears to be missi...Feature: https://source.puri.sm/Librem5/use-cases/issues/45
The backspace button shown in the [unlock screen mockup](https://gitlab.gnome.org/Teams/Design/os-mockups/blob/master/mobile-shell/mobile-shell-screens.png) appears to be missing in the current devkit build (phosh version 0.0.3~567.gbp38a86e).
https://source.puri.sm/Librem5/phosh/-/issues/73Lock screen displays incorrectly in landscape orientation2020-01-11T10:52:40ZDavid BoddieLock screen displays incorrectly in landscape orientationFeature: https://source.puri.sm/Librem5/use-cases/issues/45
# What problem did you encounter
The lock screen is incorrectly displayed in landscape orientation.
## What is the current behaviour?
The lock screen is truncated in landscape...Feature: https://source.puri.sm/Librem5/use-cases/issues/45
# What problem did you encounter
The lock screen is incorrectly displayed in landscape orientation.
## What is the current behaviour?
The lock screen is truncated in landscape orientation. The arrows are missing from the clock screen, and the bottom row of buttons are missing on the keypad screen.
## What is the expected behaviour?
All the controls should be visible.
## How to reproduce
* Open the top panel to access the Rotation slider.
* Enable it to switch to landscape orientation.
* Wait until the shell locks the screen.
![phosh-lock-landscape-1-small](/uploads/3096926080db6da3a7455831ff499c43/phosh-lock-landscape-1-small.png)
![phosh-lock-landscape-2-small](/uploads/590d253c0e6a9c200027371e7a8668a4/phosh-lock-landscape-2-small.png)
# Which version did you encounter the bug in?
- [ ] I Compiled it myself. If you compiled phosh from source please provide the
git revision via e.g. by running ``git log -1 --pretty=oneline`` and pasting
the output below.
- [x] I used the precompiled Debian package (e.g. by running a prebuilt
image). Please paste the output oof ``dpkg -s phosh`` below.
```
Phosh Version: 0.0.3~567.gbp38a86e
```
# What hardware are you running phosh on?
- [ ] amd64 qemu image
- [x] Librem5 devkit
- [ ] nested compositor. If so please give the full command you start phosh
with.
- [ ] other (please elaborte)https://source.puri.sm/Librem5/phosh/-/issues/105Unlock->Info screen animation should be reversed2019-08-21T08:14:10ZTobias BernardUnlock->Info screen animation should be reversedThe spatial model of the lock screen is that the "info" screen with time, date, etc. is above the "unlock" screen with the keypad. When going from info to unlock, the animation reflects this correctly (both screens move up), but when goi...The spatial model of the lock screen is that the "info" screen with time, date, etc. is above the "unlock" screen with the keypad. When going from info to unlock, the animation reflects this correctly (both screens move up), but when going back to info, the info screen comes back in from the bottom. In order to keep the spatial model consistent this should be reversed, i.e. both screens should move back down, the opposite of the info->unlock animation.
![phosh-lockscreen-stack-animation](/uploads/57ae9b563323ea87c5cff861ffcb0bf0/phosh-lockscreen-stack-animation.webm)
I had a quick look at the code but couldn't find an easy way to flip it. I think it should be transition type on the stack.https://source.puri.sm/Librem5/phosh/-/issues/108swipe animation uses 20% cpu time on the lockscreen2019-07-04T16:04:55ZGuido Guntherswipe animation uses 20% cpu time on the lockscreenthe pulsating arrow eats way too much cpu (draining battery). Removing the animiation makes phosh drop to almost no cpu usage.
Thanks @rinigus for noticing.
cc: @tobias.bernardthe pulsating arrow eats way too much cpu (draining battery). Removing the animiation makes phosh drop to almost no cpu usage.
Thanks @rinigus for noticing.
cc: @tobias.bernardhttps://source.puri.sm/Librem5/phosh/-/issues/111Phosh WiFi doesn't show on time-out lock-screen2019-07-01T08:14:51ZTodd WeaverPhosh WiFi doesn't show on time-out lock-screen# What problem did you encounter
WiFi appears on boot-up lock-screen, but not on the idle-time-out lock-screen
## What is the current behaviour?
No WiFi icon on time-out lockscreen
## What is the expected behaviour?
Same behavior sh...# What problem did you encounter
WiFi appears on boot-up lock-screen, but not on the idle-time-out lock-screen
## What is the current behaviour?
No WiFi icon on time-out lockscreen
## What is the expected behaviour?
Same behavior should be for time-out lock-screen as boot-up lock-screen, which is to show the WiFi icon
## How to reproduce
1. Boot device with working WiFi; see icon
2. unlock and still see WiFi icon
3. Wait idly until lock-screen re-appears
4. Notice no WiFi icon.
Video showing no WiFi on time-out lock-screen, then unlocking to show WiFi is indeed active.
![phosh-wifi-not-on-lock-screen](/uploads/f086dbf68514e5bffc15ba84a06e97e5/phosh-wifi-not-on-lock-screen.webm)
# Which version did you encounter the bug in?
- [ ] I Compiled it myself. If you compiled phosh from source please provide the
git revision via e.g. by running ``git log -1 --pretty=oneline`` and pasting
the output below.
- [x] I used the precompiled Debian package (e.g. by running a prebuilt
image). Please paste the output oof ``dpkg -s phosh`` below.
```
Package: phosh
Status: install ok installed
Priority: optional
Section: x11
Installed-Size: 547
Maintainer: Guido G�ünther <agx@sigxcpu.org>
Architecture: arm64
Version: 0.0.4~659.gbp55a20a
Provides: polkit-1-auth-agent
Depends: dconf-gsettings-backend | gsettings-backend, libc6 (>= 2.17), libcairo2 (>= 1.2.4), libgcr-base-
3-1 (>= 3.8.0), libgcr-ui-3-1 (>= 3.8.0), libgdk-pixbuf2.0-0 (>= 2.22.0), libglib2.0-0 (>= 2.55.1), libgn
ome-desktop-3-17 (>= 3.17.92), libgtk-3-0 (>= 3.19.12), libhandy-0.0-0 (>= 0.0~git20180429), libnm0 (>= 1
.0.0), libpam0g (>= 0.99.7.1), libpango-1.0-0 (>= 1.22.0), libpangocairo-1.0-0 (>= 1.14.0), libpolkit-age
nt-1-0 (>= 0.99), libpolkit-gobject-1-0 (>= 0.94), libpulse-mainloop-glib0 (>= 0.99.1), libpulse0 (>= 0.9
9.1), libupower-glib3 (>= 0.99.4-3~), libwayland-client0 (>= 1.9.91), fonts-lato
Recommends: gnome-session
Description: Pure Wayland shell for mobile devices
Phosh is a simple shell for Wayland compositors speaking the layer-surface
protocol. It currently supports
.
* a lockscreen
* brightness control and nighlight
* the gcr system-prompter interface
* acting as a polkit auth agent
* enough of org.gnome.Mutter.DisplayConfig to make gnome-settings-daemon happy
* a homebutton that toggles a simple favorites menu
* status icons for battery, wwan and wifi
.
If you're not working on a Wayland compositor then this package is likely not
very useful for you.
Homepage: https://source.puri.sm/Librem5/phosh
```
# What hardware are you running phosh on?
- [ ] amd64 qemu image
- [x] Librem5 devkit
- [ ] nested compositor. If so please give the full command you start phosh
with.
- [ ] other (please elaborte)Heather EllsworthHeather Ellsworthhttps://source.puri.sm/Librem5/phosh/-/issues/134Small font size for date on lockscreen2019-12-25T03:55:33ZAdemeion AdemoSmall font size for date on lockscreenFont size used to show date on the lockscreen seems unreasonably small. Compared to time it's tiny. In many situations and for many the date will probably be difficult to read.
Perhaps the design is (unconsciously) taken from Android, ...Font size used to show date on the lockscreen seems unreasonably small. Compared to time it's tiny. In many situations and for many the date will probably be difficult to read.
Perhaps the design is (unconsciously) taken from Android, where it is similar, but I think in this case it would be good to deviate from Android's design. At least it would be good to have an option to change the size (which Android doesn't allow).
Current lockscreen (as shown in Librem 5 July Update):
[](https://puri.sm/wp-content/uploads/2019/07/256-512c.png)https://source.puri.sm/Librem5/phosh/-/issues/225Single digit date appears as two digit with leading 02020-12-24T09:01:21ZTodd WeaverSingle digit date appears as two digit with leading 0# What problem did you encounter
Leading zero on single digit date
## What is the current behaviour?
'January 02' rather than 'January 2'
## What is the expected behaviour?
'January 2'
## How to reproduce
Set the date to a single ...# What problem did you encounter
Leading zero on single digit date
## What is the current behaviour?
'January 02' rather than 'January 2'
## What is the expected behaviour?
'January 2'
## How to reproduce
Set the date to a single digit day, see lock screen.
```
purism@pureos:~$ uname -a
Linux pureos 5.3.0-librem5-h1 #1 SMP PREEMPT Tue Dec 24 15:42:56 CET 2019 aarch64 GNU/Linux
purism@pureos:~$ dpkg -s phosh | grep Version
Version: 0.1.5
purism@pureos:~$
```
# What hardware are you running phosh on?
- Librem 5 Chestnuthttps://source.puri.sm/Librem5/phosh/-/issues/235Lockscreen: "Submit" button issues2020-02-21T15:35:32ZTobias BernardLockscreen: "Submit" button issuesJust tested the new lock screen, and here are a few things I noticed:
- The "Submit" button is pretty far from the edge of the screen, making it not as ergonomic as it could be. I'd move just move the entire content of this page down 10...Just tested the new lock screen, and here are a few things I noticed:
- The "Submit" button is pretty far from the edge of the screen, making it not as ergonomic as it could be. I'd move just move the entire content of this page down 100px or so, like on the mockups
- Unlike on the mockups, I think the label on the button should say "Unlock" instead of "Submit". We discussed this a while ago, but I guess I never got around to updating them since :)
![Screenshot_from_2020-01-10_19-11-52](/uploads/8326a5973e5d5284c1849389c3e717d2/Screenshot_from_2020-01-10_19-11-52.png)https://source.puri.sm/Librem5/phosh/-/issues/236Lockscreen click+small-drag doesn't accept pin entry2021-03-22T11:43:46ZTodd WeaverLockscreen click+small-drag doesn't accept pin entry# What problem did you encounter
Entering the unlock pin sequence where a minor drag occurs fails to accept that pin entry.
## What is the current behaviour?
Commonly when using two hands and thus both thumbs to unlock a pin code, a m...# What problem did you encounter
Entering the unlock pin sequence where a minor drag occurs fails to accept that pin entry.
## What is the current behaviour?
Commonly when using two hands and thus both thumbs to unlock a pin code, a minor drag event occurs on a key press, resulting in that key not being accepted/pressed.
## What is the expected behaviour?
keypresses are accepted without drag event intervening.
## How to reproduce
![librem-5-birch-lockscreen-drag-pin-2020-01-12](/uploads/8ddcb2d0eca0b23f841b7fd2420533a4/librem-5-birch-lockscreen-drag-pin-2020-01-12.webm)
# Which version did you encounter the bug in?
```
purism@librem-5-birch:~$ dpkg -s phosh | grep Version
Version: 0.1.6
purism@librem-5-birch:~$ uname -a
Linux librem-5-birch 5.3.0-librem5-h1 #1 SMP PREEMPT Tue Jan 7 10:16:00 CET 2020 aarch64 GNU/Linux
purism@librem-5-birch:~$
```
# What hardware are you running phosh on?
- Librem 5 Birch (also Chestnut)https://source.puri.sm/Librem5/phosh/-/issues/254Don't ask for SIM PIN on lock screen2021-05-09T18:22:02ZTobias BernardDon't ask for SIM PIN on lock screenCurrently when starting the phone with a SIM in it, it will show the PIN dialog immediately, before I've actually unlocked the phone. This is a bit confusing/surprising. I'd expect to be asked for the PIN after I unlock the device, not b...Currently when starting the phone with a SIM in it, it will show the PIN dialog immediately, before I've actually unlocked the phone. This is a bit confusing/surprising. I'd expect to be asked for the PIN after I unlock the device, not before.https://source.puri.sm/Librem5/phosh/-/issues/323option to switch user on lockscreen2020-06-26T06:07:13ZMartin Kepplingeroption to switch user on lockscreenIn case one sets up a second user on the commandline, it would be nice to easily be able to run a GUI session with it.
Could we imagine for the lockscreen to check whether another user exists, and if so, offer a (small) "change user" op...In case one sets up a second user on the commandline, it would be nice to easily be able to run a GUI session with it.
Could we imagine for the lockscreen to check whether another user exists, and if so, offer a (small) "change user" option? of course this would mean displaying the username somewhere too (but still not by default so that nothing changes in case there is only our purism user set up).
This would allow to more comfortably let other people test / use the phone that holds ones own personal data.https://source.puri.sm/Librem5/phosh/-/issues/430Make play button from headset toggle mpris play/pause2021-02-11T09:19:50ZOliver SmithMake play button from headset toggle mpris play/pauseI'd find it very useful if the play button on headsets was able to toggle play/pause of the currently active mpris player. Then I could quickly toggle music / podcast playback from the headset without pulling out the phone.
The button i...I'd find it very useful if the play button on headsets was able to toggle play/pause of the currently active mpris player. Then I could quickly toggle music / podcast playback from the headset without pulling out the phone.
The button is available as `XF86AudioPlay`, so with the following patch, I can get phosh to log a message when the button is pressed.
The mpris code to check if the player can play/pause, and to actually do it, is used in `src/media-player.c` already (e.g. `phosh_mpris_dbus_media_player2_player_call_play_pause`). However, it needs the dbus player object as first parameter, which isn't available in `src/settings.c`.
If this feature is wanted, it would be great if you could give me a pointer of how it should be implemented.
<details>
```diff
--- a/src/settings.c
+++ b/src/settings.c
@@ -79,10 +79,12 @@ G_DEFINE_TYPE (PhoshSettings, phosh_settings, GTK_TYPE_BIN)
static void raise_volume (GSimpleAction *action, GVariant *param, gpointer self);
static void lower_volume (GSimpleAction *action, GVariant *param, gpointer self);
+static void play (GSimpleAction *action, GVariant *param, gpointer self);
const GActionEntry action_entries[] = {
{ "XF86AudioLowerVolume", lower_volume, },
{ "XF86AudioRaiseVolume", raise_volume, },
+ { "XF86AudioPlay", play, },
};
static void
@@ -224,6 +226,14 @@ raise_volume (GSimpleAction *action, GVariant *param, gpointer self)
change_volume (PHOSH_SETTINGS (self), 1);
}
+static void
+play (GSimpleAction *action, GVariant *param, gpointer self)
+{
+ g_return_if_fail (PHOSH_IS_SETTINGS (self));
+
+ g_debug ("Play button pressed");
+}
+
static void
update_output_vol_bar (PhoshSettings *self)
```
</details>https://source.puri.sm/Librem5/phosh/-/issues/444Unlocking fails randomly after a while2021-01-20T09:09:16ZDylan Van Asscheme@dylanvanassche.beUnlocking fails randomly after a while# What problem did you encounter
I noticed that after a while, Phosh randomly fails to unlock.
This happens rarely and is difficult to reproduce, however, I managed to get the logs:
```
(phosh:2986): phosh-lockscreen-manager-CRITICAL *...# What problem did you encounter
I noticed that after a while, Phosh randomly fails to unlock.
This happens rarely and is difficult to reproduce, however, I managed to get the logs:
```
(phosh:2986): phosh-lockscreen-manager-CRITICAL **: 07:37:08.147: lockscreen_unlock_cb: assertion 'lockscreen == PHOSH_LOCKSCREEN (self->lockscreen)' failed
```
Only this is logged when trying to unlock when the bug appears.
## What is the current behaviour?
Sometimes you cannot unlock the lockscreen, even with the right PIN entered.
## What is the expected behaviour?
Unlock always works
## How to reproduce
1. Use the device
2. Sleep/resume
3. Randomly, the lockscreen cannot be unlocked anymore
# Which version did you encounter the bug in?
- [ ] I Compiled it myself. If you compiled phosh from source please provide the
git revision via e.g. by running ``git log -1 --pretty=oneline`` and pasting
the output below.
- [x] I used the precompiled Debian package (e.g. by running a prebuilt
image). Please paste the output oof ``dpkg -s phosh`` below.
```
Phosh Version: 0.6.0
```
# What hardware are you running phosh on?
- [ ] amd64 qemu image
- [ ] Librem5 devkit
- [ ] nested compositor. If so please give the full command you start phosh
with.
- [x] other: PinePhone pmOS 3GB with pmOS edge.
# Releveant logfiles
```
(phosh:2986): phosh-lockscreen-manager-CRITICAL **: 07:37:08.147: lockscreen_unlock_cb: assertion 'lockscreen == PHOSH_LOCKSCREEN (self->lockscreen)' failed
```
https://source.puri.sm/Librem5/phosh/-/issues/556lockscreen: Enable custom message2022-06-01T15:56:16ZPavel Macheklockscreen: Enable custom messageWhen the phone is lost, whoever found it will not be able to unlock it. Still, it would be nice to have a way to display text ("This is Pavel's phone, please return it to him, he's on yellow horse somewhere around").When the phone is lost, whoever found it will not be able to unlock it. Still, it would be nice to have a way to display text ("This is Pavel's phone, please return it to him, he's on yellow horse somewhere around").https://source.puri.sm/Librem5/phosh/-/issues/558lockscreen: PIN should be optional2022-06-01T15:55:21ZPavel Macheklockscreen: PIN should be optionalHaving password to unlock the phone is usually good idea, but there are exceptions. Some people move in safe environments, and some software runs on development boards where bad people don't have physical access. It should be possible to...Having password to unlock the phone is usually good idea, but there are exceptions. Some people move in safe environments, and some software runs on development boards where bad people don't have physical access. It should be possible to disable PIN entry for such situations. (PIN entry should also not be needed for fingerprint/face recognition etc.)