phosh issueshttps://source.puri.sm/Librem5/phosh/-/issues2019-09-17T06:13:32Zhttps://source.puri.sm/Librem5/phosh/-/issues/167notifications: Allow to silence message bubble2019-09-17T06:13:32ZGuido Gunthernotifications: Allow to silence message bubbleHandle `org.gnome.desktop.notifications` `show-banners`Handle `org.gnome.desktop.notifications` `show-banners`https://source.puri.sm/Librem5/phosh/-/issues/165notifications: Implement actions2019-09-25T15:54:07ZGuido Gunthernotifications: Implement actionshttps://source.puri.sm/Librem5/phosh/-/issues/187Center notification button labels2020-03-25T11:56:36ZTobias BernardCenter notification button labelsThe labels on the notification action button should be centered instead of left-aligned.
![image](/uploads/22bcfa1aca95c5e0a66d7a2bc7ba8c6b/image.png)The labels on the notification action button should be centered instead of left-aligned.
![image](/uploads/22bcfa1aca95c5e0a66d7a2bc7ba8c6b/image.png)https://source.puri.sm/Librem5/phosh/-/issues/245Implement Notification Center2020-08-27T06:57:09ZKyle RankinImplement Notification CenterRelated to #166 but for the main screen. When a notification appears it only lasts a few seconds and then disappears. It would be nice if there were a mechanism like there is on regular Gnome Shell to review and dismiss notifications tha...Related to #166 but for the main screen. When a notification appears it only lasts a few seconds and then disappears. It would be nice if there were a mechanism like there is on regular Gnome Shell to review and dismiss notifications that appear on the screen and then disappear.
Presumably this would be something that would be accessible from the top bar and again, similar to how it's handled in Gnome Shell with a number to the left or right of the current time for the current unviewed notifications. Selecting that in some way would allow the user to view and dismiss the notifications.https://source.puri.sm/Librem5/phosh/-/issues/309notifications: blink led on missed notifications2020-09-11T17:21:11ZGuido Gunthernotifications: blink led on missed notificationsWill be handled via feedbackd once LED support is in, just a bug to track this.Will be handled via feedbackd once LED support is in, just a bug to track this.https://source.puri.sm/Librem5/phosh/-/issues/450Drop timestamp from notification banners2020-12-11T09:21:19ZGuido GuntherDrop timestamp from notification bannersThe timestamp makes no sense on banners since they show up immediately so we can drop them there (while keeping them in the tray).The timestamp makes no sense on banners since they show up immediately so we can drop them there (while keeping them in the tray).https://source.puri.sm/Librem5/phosh/-/issues/321notifications: critical on notification update2021-05-28T22:10:33ZGuido Gunthernotifications: critical on notification updatei'm seeing this when mumble updates a notificatio
```
(phosh:30489): phosh-notification-content-CRITICAL **: 16:18:04.757: set_actions: assertion 'PHOSH_IS_NOTIFICATION_CONTENT (self)' failed
Thread 1 "phosh" received signal SIGTRAP, T...i'm seeing this when mumble updates a notificatio
```
(phosh:30489): phosh-notification-content-CRITICAL **: 16:18:04.757: set_actions: assertion 'PHOSH_IS_NOTIFICATION_CONTENT (self)' failed
Thread 1 "phosh" received signal SIGTRAP, Trace/breakpoint trap.
_g_log_abort (breakpoint=1) at ../../../glib/gmessages.c:554
554 ../../../glib/gmessages.c: No such file or directory.
(gdb) bt
#0 _g_log_abort (breakpoint=1) at ../../../glib/gmessages.c:554
#1 0x00007ffff718f869 in g_logv (log_domain=0x5555555d6caa "phosh-notification-content", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffc880)
at ../../../glib/gmessages.c:1373
#2 0x00007ffff718fa2f in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at ../../../glib/gmessages.c:1415
#6 0x00007ffff7291edf in <emit signal notify:actions on instance 0x5555561ab440 [PhoshNotification]> (instance=instance@entry=0x5555561ab440, signal_id=<optimized out>, detail=<optimized out>)
at ../../../gobject/gsignal.c:3554
#3 0x00007ffff7272fd2 in g_closure_invoke (closure=0x555556732f60, return_value=0x0, n_param_values=2, param_values=0x7fffffffcb20, invocation_hint=0x7fffffffcaa0) at ../../../gobject/gclosure.c:810
#4 0x00007ffff7286784 in signal_emit_unlocked_R
(node=node@entry=0x55555564f310, detail=detail@entry=2360, instance=instance@entry=0x5555561ab440, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7fffffffcb20)
at ../../../gobject/gsignal.c:3742
#5 0x00007ffff729154f in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7fffffffccf0) at ../../../gobject/gsignal.c:3498
#7 0x00007ffff7277624 in g_object_dispatch_properties_changed (object=0x5555561ab440 [PhoshNotification], n_pspecs=<optimized out>, pspecs=<optimized out>) at ../../../gobject/gobject.c:1206
#8 0x00007ffff7276f4d in g_object_notify_queue_thaw (object=object@entry=0x5555561ab440 [PhoshNotification], nqueue=nqueue@entry=0x555555b26720) at ../../../gobject/gobject.c:341
#9 0x00007ffff727ae49 in g_object_set_valist
(object=object@entry=0x5555561ab440 [PhoshNotification], first_property_name=first_property_name@entry=0x5555555d5700 "app_name", var_args=var_args@entry=0x7fffffffcfb0) at ../../../gobject/gobject.c:2448
#10 0x00007ffff727b9ac in g_object_set (_object=0x5555561ab440, first_property_name=first_property_name@entry=0x5555555d5700 "app_name") at ../../../gobject/gobject.c:2612
#11 0x00005555555b2296 in handle_notify
(skeleton=0x5555557bd690, invocation=0x7fffe809b470 [GDBusMethodInvocation], app_name=0x555557045af0 "Mumble", replaces_id=2, app_icon=<optimized out>, summary=0x555557353800 "User left channel and disconnected", body=0x5555558776e0 "Kyle Rankin left channel and disconnected.", actions=0x555556bd8c30, hints=0x7fffe809f930, expire_timeout=<optimized out>) at ../src/notifications/notify-manager.c:390
#12 0x00007ffff5a3dccd in () at /usr/lib/x86_64-linux-gnu/libffi.so.7
#13 0x00007ffff5a3d25a in () at /usr/lib/x86_64-linux-gnu/libffi.so.7
Python Exception <class 'gdb.error'> There is no member named v_pointer.:
#17 0x00007ffff72908af in #18 0x00005555555899dc in _phosh_notify_dbus_notifications_skeleton_handle_method_call
(connection=<optimized out>, sender=<optimized out>, object_path=<optimized out>, interface_name=0x7fffe8060400 "org.freedesktop.Notifications", method_name=0x7fffe806ec70 "Notify", parameters=<optimized out>, invocation=0x7fffe809b470 [GDBusMethodInvocation], user_data=0x5555557bd690) at src/dbus/notify-dbus.c:1737
#19 0x00007ffff73ddd4a in g_dbus_interface_method_dispatch_helper
(interface=<optimized out>, method_call_func=0x555555589820 <_phosh_notify_dbus_notifications_skeleton_handle_method_call>, invocation=0x7fffe809b470 [GDBusMethodInvocation])
at ../../../gio/gdbusinterfaceskeleton.c:613
#20 0x00007ffff73c4e10 in call_in_idle_cb (user_data=<optimized out>) at ../../../gio/gdbusconnection.c:4888
#21 0x00007ffff71884de in g_main_dispatch (context=0x55555566a800) at ../../../glib/gmain.c:3309
#22 g_main_context_dispatch (context=context@entry=0x55555566a800) at ../../../glib/gmain.c:3974
#23 0x00007ffff7188890 in g_main_context_iterate (context=0x55555566a800, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:4047
#24 0x00007ffff7188b63 in g_main_loop_run (loop=0x5555556bf0c0) at ../../../glib/gmain.c:4241
#25 0x00007ffff791be85 in gtk_main () at ../../../../gtk/gtkmain.c:1328
#26 0x000055555556e70f in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:91
```
@zbrown maybe you have an immediate idea?Guido GuntherGuido Guntherhttps://source.puri.sm/Librem5/phosh/-/issues/451RFC: disable haptic/led feedback if not showing a notification banner2021-07-23T17:22:20ZGuido GuntherRFC: disable haptic/led feedback if not showing a notification bannerShould we disable haptic and LED feedback when an using a notification banner is disabled for an appliction? This would make the notification very 'silent' by only putting it into the tray without any feedback so i tend to 'no'. It might...Should we disable haptic and LED feedback when an using a notification banner is disabled for an appliction? This would make the notification very 'silent' by only putting it into the tray without any feedback so i tend to 'no'. It might be a good thing so one doesn't have to disable app notifications completely.https://source.puri.sm/Librem5/phosh/-/issues/166notifications: allow to show on lock screen2021-08-09T08:20:41ZGuido Gunthernotifications: allow to show on lock screenthis needs privacy handling as well so there's more to it than just the widget. See e.g. (`org.gnome.desktop.notifications` `show-in-lock-screen`)this needs privacy handling as well so there's more to it than just the widget. See e.g. (`org.gnome.desktop.notifications` `show-in-lock-screen`)https://source.puri.sm/Librem5/phosh/-/issues/169notifications: handle x-gnome-privacy-scope2021-08-09T08:20:41ZGuido Gunthernotifications: handle x-gnome-privacy-scopehttps://source.puri.sm/Librem5/phosh/-/issues/221Notifications without body don't show up2021-08-09T08:20:42ZSebastian KrzyszkowiakNotifications without body don't show upNotifications contain summary and optional body. However, in Phosh notifications without body fail to show up properly.
To reproduce:
`notify-send "lorem ipsum"`
You'll see that something (single pixel line?) shows up on the screen, b...Notifications contain summary and optional body. However, in Phosh notifications without body fail to show up properly.
To reproduce:
`notify-send "lorem ipsum"`
You'll see that something (single pixel line?) shows up on the screen, but hides after a split second.
Notifications with body (like `notify-send "lorem ipsum" "dolor sit amet"`) work fine.https://source.puri.sm/Librem5/phosh/-/issues/246Notifications Stack On Top Of Each Other2021-08-09T08:20:42ZKyle RankinNotifications Stack On Top Of Each Other# Problem Statement
Currently when more than one notification occurs at a time, the most recent notification covers others up so that one can only view a single notification.
# Expected Behavior
Like with Gnome Shell notifications, new ...# Problem Statement
Currently when more than one notification occurs at a time, the most recent notification covers others up so that one can only view a single notification.
# Expected Behavior
Like with Gnome Shell notifications, new notifications appear below existing notifications and when a notification goes away, any notifications below it move up to fill its space.
# Steps to Reproduce
* `notify-send test1 test1; notify-send test2 test2; notify-send test3 test3`
* Note that they all quickly appear but only test3 is visible
* Tapping a notification makes it disappear and reveals notifications below it that haven't timed out.https://source.puri.sm/Librem5/phosh/-/issues/351Notification with timeout aren't being removed from the message tray2021-08-09T08:20:45ZGuido GuntherNotification with timeout aren't being removed from the message traycan be checked with `notify-send -t 3000 asdf sadf` - the notification sticks in the tray even after 3 seconds.can be checked with `notify-send -t 3000 asdf sadf` - the notification sticks in the tray even after 3 seconds.https://source.puri.sm/Librem5/phosh/-/issues/352'Really' Persistent notifications2021-08-09T08:20:45ZGuido Gunther'Really' Persistent notificationsNotifications aren't e.g. stored across reboots / poweroffs. We should keep them around.Notifications aren't e.g. stored across reboots / poweroffs. We should keep them around.https://source.puri.sm/Librem5/phosh/-/issues/377Notifications don't disappear with an animation2021-08-09T08:20:46ZJulian SparberNotifications don't disappear with an animationThe notifications slide in from the top but then just disappear. I think they should slide back up.
cc: @tobias.bernardThe notifications slide in from the top but then just disappear. I think they should slide back up.
cc: @tobias.bernardhttps://source.puri.sm/Librem5/phosh/-/issues/442Unable to clear terminal notification (unable to clear any notification unles...2021-08-09T08:20:49ZTodd WeaverUnable to clear terminal notification (unable to clear any notification unless you 'activate' it)# What problem did you encounter
Cannot clear a notification
## What is the current behaviour?
Unable to clear a notification unless you activate the notification button
## What is the expected behaviour?
Swipe clear notifications p...# What problem did you encounter
Cannot clear a notification
## What is the current behaviour?
Unable to clear a notification unless you activate the notification button
## What is the expected behaviour?
Swipe clear notifications probably.
## How to reproduce
1. Run a terminal command
2. Let it complete
3. Get the notification
4. Cannot clear it (video below is docked)
![purism-librem-5-pureos-phosh-notification-not-clearing-2020-11-28](/uploads/e9bea72d2932b433b9a9b7045c4e9754/purism-librem-5-pureos-phosh-notification-not-clearing-2020-11-28.webm)
# Which version did you encounter the bug in?
```
purism@pureos:~$ uname -a
Linux pureos 5.9.0-1-librem5 #1 SMP PREEMPT Fri Nov 27 19:15:53 UTC 2020 aarch64 GNU/Linux
purism@pureos:~$ dpkg -s phosh | grep Version
Version: 0.6.0
purism@pureos:~$ dpkg -s phoc | grep Version
Version: 0.5.1
purism@pureos:~$```
# What hardware are you running phosh on?
- Librem 5 Evergreenhttps://source.puri.sm/Librem5/phosh/-/issues/458PhoshNotifyManager for DBus only2021-08-09T08:20:49ZZander Brownzbrown@gnome.orgPhoshNotifyManager for DBus onlyIdeally things like automount notifications would only have to interact with `PhoshNotificationList`
The following discussion from !668 should be addressed:
- [ ] @zbrown started a [discussion](https://source.puri.sm/Librem5/phosh/-/m...Ideally things like automount notifications would only have to interact with `PhoshNotificationList`
The following discussion from !668 should be addressed:
- [ ] @zbrown started a [discussion](https://source.puri.sm/Librem5/phosh/-/merge_requests/668#note_132997): (+1 comment)
> Hmm, would have been nice to operate on `PhoshNotificationList` directly and keep `PhoshNotifyManager`, though a `phosh_notify_manager_claim_id` would still be neededhttps://source.puri.sm/Librem5/phosh/-/issues/473Notification buttons should prefer horizontal layout2021-08-09T08:20:50ZEvangelos Ribeiro TzarasNotification buttons should prefer horizontal layoutThis came up in the threads https://source.puri.sm/Librem5/calls/-/merge_requests/231#note_137153 and https://source.puri.sm/Librem5/calls/-/merge_requests/231#note_137341 (be sure to expand the threads)
so I thought it might be a good i...This came up in the threads https://source.puri.sm/Librem5/calls/-/merge_requests/231#note_137153 and https://source.puri.sm/Librem5/calls/-/merge_requests/231#note_137341 (be sure to expand the threads)
so I thought it might be a good idea to have the discussion here.
Attaching screenshots of how it would currently look if one added a second button to the notification:
![calls_missed_0](/uploads/80b051b62350fdf02c6b69126eb3465a/calls_missed_0.png)
![calls_missed_1](/uploads/a16a6b8e69cda352fc4d98a244f52bfd/calls_missed_1.png)https://source.puri.sm/Librem5/phosh/-/issues/286Notification bubble: minor visual issues2021-08-09T12:03:34ZTobias BernardNotification bubble: minor visual issuesThe notification bubbles look quite good already, but there are a few small papercuts, specifically:
- The app symbolic icon should be dimmed
- There should be a little bit less horizontal space between the symbolic icon and app name (ma...The notification bubbles look quite good already, but there are a few small papercuts, specifically:
- The app symbolic icon should be dimmed
- There should be a little bit less horizontal space between the symbolic icon and app name (maybe 2 or 3px less)
- There's a bit too much vertical space below the app name/icon. I'd reduce that by a few pixels.
![image](/uploads/95ac27ace02f4f5efad0f44317cfad36/image.png)https://source.puri.sm/Librem5/phosh/-/issues/570Notifications: close all button2022-06-01T15:55:20ZGuido GuntherNotifications: close all buttonThere's a 'close all' button for notifications in gnome-shell iirc, should we have that too?
/cc @tobias.bernardThere's a 'close all' button for notifications in gnome-shell iirc, should we have that too?
/cc @tobias.bernard