Skip to content

Use common base class for system-modal dialogs

Guido Gunther requested to merge guido.gunther/phosh:system-modal-dialog into master

Builing on !754 (merged) which got the dialogs in line style wise this now adds a common base class for all system-modal dialogs so they stay in sync in the future:

  • Adds PhoshSystemModalDialog class
  • Switches PhoshNetworkAuthPrompt, SystemAuthPrompt and PolkitAuthPrompt over
  • Make PolkitAuthPrompt follow the designs as well (Closes: #536 (closed))

With that i could then

  • Drop heaps of different margins, paddings, spacins and let the style classed do their job
  • Drop duplicate ESC key handling
  • Make the dialogs swipe-away so the can be closed via swipe-up
  • Use a HdyClamp to make sure the don't get arbitrary wide

This is on top of the geoclue MR so either one can go in first. I'll likely merge geoclue but the corresponding patch to mre the dialog over is separate (app-auth-prompt: Use system-modal-dialog) so either one can go in first.

Edited by Guido Gunther

Merge request reports