Skip to content
Snippets Groups Projects

brightness: Fix brightness setting

Merged Guido Gunther requested to merge guido.gunther/phosh:brightness-set into master

At least with 3.24.12 when we receive the brightness_changed_cb we must not mark ourself as setting brightness since otherwise we bail out early out out of brightness_set() never resetting setting_brightness. This unbreaks making brightness setting only work the first time.

Signed-off-by: Guido Günther guido.gunther@puri.sm

Merge request reports

Pipeline #44720 passed

Pipeline passed for ead30dc6 on guido.gunther:brightness-set

Test coverage 8.70% (0.00%) from 2 jobs
Approval is optional

Merged by Sebastian KrzyszkowiakSebastian Krzyszkowiak 5 years ago (Nov 13, 2019 3:40am UTC)

Merge details

  • Changes merged into master with ead30dc6.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #44721 passed

Pipeline passed for ead30dc6 on master

Test coverage 8.70% (0.00%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading